Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] max_grad_norm not effect #6743

Open
yiyepiaoling0715 opened this issue Nov 12, 2024 · 2 comments
Open

[BUG] max_grad_norm not effect #6743

yiyepiaoling0715 opened this issue Nov 12, 2024 · 2 comments
Labels
bug Something isn't working compression

Comments

@yiyepiaoling0715
Copy link

yiyepiaoling0715 commented Nov 12, 2024

Describe the bug
A clear and concise description of what the bug is.
deepseed config gradient_clip set as auto
max_grad_norm set as 1.0
but it not effects
deepspeed version is 0.14.5,when i change to 0.15.3,0.15.4,it has the same quesiton.
I use Firefly sft as the train repo
To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error
    Image
    Image
    Image
    Image
    Image
    Image

Expected behavior
A clear and concise description of what you expected to happen.

ds_report output
Please run ds_report to give us details about your setup.

Screenshots
If applicable, add screenshots to help explain your problem.

System info (please complete the following information):

  • OS: [e.g. Ubuntu 18.04]
  • GPU count and types [e.g. two machines with x8 A100s each]
  • Interconnects (if applicable) [e.g., two machines connected with 100 Gbps IB]
  • Python version
  • Any other relevant info about your setup

Launcher context
Are you launching your experiment with the deepspeed launcher, MPI, or something else?

Docker context
Are you using a specific docker image that you can share?

Additional context
Add any other context about the problem here.

@yiyepiaoling0715 yiyepiaoling0715 added bug Something isn't working compression labels Nov 12, 2024
@yiyepiaoling0715
Copy link
Author

Image

@chengmengli06
Copy link

it seems that they do not implement it at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compression
Projects
None yet
Development

No branches or pull requests

2 participants