Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all config values to use ServiceExtensionContext#getSetting #51

Open
paullatzelsperger opened this issue Apr 29, 2021 · 0 comments
Open

Consolidate all config values to use ServiceExtensionContext#getSetting #51

paullatzelsperger opened this issue Apr 29, 2021 · 0 comments
Assignees
@paullatzelsperger

Comments

@paullatzelsperger
Copy link
Collaborator

paullatzelsperger commented Apr 29, 2021 •
edited
Loading

instead of directly reading System properties or environment variables, all properties should be obtained using ServiceExtensionContext#getSetting().
The naming should be dagx.<extension>.<propertyname>, and every property should be annotated with the @DagxSetting annotation.
@paullatzelsperger paullatzelsperger self-assigned this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paullatzelsperger paullatzelsperger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paullatzelsperger