Skip to content

track warning about zipkin dependency #509

Open
@codefromthecrypt

Description

@codefromthecrypt

This warning says brave has a dependency on zipkin, which is currently true for a transient reason. Once that goes away, the note here should be removed:

IMPORTANT: Remember that Brave by default adds Zipkin as a dependency. If you want to use just Wavefront and you're using classpath dependant solutions such as Spring Boot, you might be required to exclude the transitive dependency on Zipkin when using Brave (e.g. via exlcuding the `io.zipkin.reporter2` group).

The reason is that brave temporarily pinned the zipkin reporter version in case the api drifted. No one removed that in 3 years, so it should be done shortly and once micrometer uses an updated version of brave, the above warning should go away: https://github.com/openzipkin/brave/blob/master/brave/pom.xml#L43-L49

Note: those who aren't using wavefront and choosing to use zipkin-reporter-brave will still have a sneaky dep on zipkin2 until a major version release of zipkin-reporter which would remove these deps. This would only affect those adding the zipkin reporter dependency so is a different thing than the wavefront thing, rather just a note fyi openzipkin/zipkin-reporter-java#182

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions