Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate micrometer-registry-signalfx #5807

Open
johnowl opened this issue Jan 14, 2025 · 2 comments · May be fixed by #5813
Open

Deprecate micrometer-registry-signalfx #5807

johnowl opened this issue Jan 14, 2025 · 2 comments · May be fixed by #5813
Labels
enhancement A general enhancement registry: signalfx A SignalFX Registry related issue release notes Noteworthy change to call out in the release notes
Milestone
1.15.0-M2

Comments

@johnowl
Copy link

johnowl commented Jan 14, 2025 •
edited
Loading

The dependency com.signalfx.public:signalfx-java, used in the micrometer-registry-signalfx` implementation is deprecated. The repository will be archived on February 1st, 2025 and will not receive any security updates anymore.

Their repository mentions:

Splunk has adopted OpenTelemetry. Use the OpenTelemetry Java SDK or the Splunk Distribution of OpenTelemetry Java Instrumentation agent to send telemetry data to Splunk. Do not integrate signalfx-java into new services.
@jonatan-ivanov
Copy link
Member

Thank you for the issue.
It does not seem that the endpoints used by signalfx-java are going to be shut down so even if the signalfx-java lib will be deprecated, it should still work for users.

I think with that in mind, we can deprecate Micrometer's SignalFX registry and since it seems SingnalFX has OTLP direct ingestion endpoints:

https://ingest.<realm>.signalfx.com/v2/trace/otlp
https://ingest.<realm>.signalfx.com/v2/datapoint/otlp

we could offer the Micrometer OTLP registry as a migration path.

Are you suing SignalFX with Micrometer? Have you tried the OTLP endpoints with Micrometer's OTLP registry?

@jonatan-ivanov jonatan-ivanov added registry: signalfx A SignalFX Registry related issue waiting for feedback We need additional information before we can continue labels Jan 14, 2025
@johnowl
Copy link
Author

johnowl commented Jan 14, 2025 •
edited
Loading

Yes, I'm using it inside a library that we distribute to the developers of our company. My next step will be refactoring this library to use the OTLP registry.

@shakuzen shakuzen changed the title Deprecated dependency: com.signalfx.public:signalfx-java Deprecate micrometer-registry-signalfx Jan 15, 2025
@shakuzen shakuzen added enhancement A general enhancement release notes Noteworthy change to call out in the release notes and removed waiting for feedback We need additional information before we can continue labels Jan 15, 2025
@shakuzen shakuzen added this to the 1.15.0-M2 milestone Jan 15, 2025
shakuzen added a commit to shakuzen/micrometer that referenced this issue Jan 20, 2025
@shakuzen
Deprecate SignalFX Registry in favor of OTLP Registry
b13a07d 
Resolves micrometer-metricsgh-5807
@shakuzen shakuzen linked a pull request Jan 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement registry: signalfx A SignalFX Registry related issue release notes Noteworthy change to call out in the release notes
Projects
None yet
Milestone
1.15.0-M2
Development

Successfully merging a pull request may close this issue.

Deprecate SignalFX Registry in favor of OTLP Registry shakuzen/micrometer
3 participants
@jonatan-ivanov @johnowl @shakuzen