Rebind log4j2 metrics if configuration is changed #5810
Conversation
* Use `PropertyChangeListener` to add the `MetricsFilter` to log4j2 if configuration is reloaded * When adding filters, check if the filter is already added * Keep `metricFilters` in a `HashMap` to avoid creating new filters each time configuration is reloaded Signed-off-by: Patrik Ivarsson <[email protected]>
Signed-off-by: Patrik Ivarsson <[email protected]>
Thanks for the review! That is a good point! I don't think it would be any big issue, as the old configuration is already stopped here, but I do think it would be cleaner to clean up any old references to I made a new commit here where I also do a cleanup of the old configuration instance. I also changed the changeListener to only do an update if the configuration instance is not the same object as the old instance (as no rebinding or cleanup should be needed then). |
pativa
force-pushed
the
log4j2-reconfigure-rebind
branch
from
96dafd3 to
4361d51
Compare
Signed-off-by: Patrik Ivarsson <[email protected]>
pativa
force-pushed
the
log4j2-reconfigure-rebind
branch
from
4361d51 to
41d0e7e
Compare
Intended to verify that we don't continually create more filters when reloading config Signed-off-by: Patrik Ivarsson <[email protected]>
Describe the issue
This PR is intended to fix #5756
When log4j2 metrics are reconfigured, metrics will no longer be recorded. For example, if
monitorInterval(docs) is configured to 30 is used and configuration is reloaded after application start, metrics would only be recorded for the first 30 seconds.By using a
PropertyChangeListener, it looks like we can register theMetricsFilterin much the same way, but it will be rebound after reloading the configuration. All the previous tests seem to pass too when using this method of configuration.