-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to configure OTEL Semantic Conventions for JVM metrics #5286
Comments
Since in Micrometer we consider changing existing meter names and tags a breaking change, I'm not sure how we would do this outside a new major version. Any ideas?
I also wouldn't tie a wire format (OTLP) to a semantic convention - I think they should be separate decisions. It should be valid to use OpenTelemetry semantic conventions with a format other than OTLP and it should be valid to use OTLP without using the OpenTelemetry semantic conventions. |
Add additional OTEL specific MeterBinder implementations in addition to the JVM ones? |
I am working on something within our organization. It is a bit of hybrid approach with using MeterFilter for renaming existing things and an additional MeterBinder for missing pieces. I can create a follow-up PR if we agree on the approach in this issue. Yeah, this should be a opt-in thing for the reason @shakuzen mentioned above. |
As an alternative to the |
I've updated the labels and issue title. I suppose the most basic implementation might be to add a constructor argument (boolean?) to the relevant MeterBinder implementations so users can choose whether to use the otel semantic conventions for the relevant metrics provided by the MeterBinder. A concern I have is around future changes to the semantic conventions and how we could support that. We are planning to work on addressing that with ObservationConventions, but metrics (not through the Observation API) are outside of the scope of that. Making a MeterFilter is another option, but I think that might be more brittle than something in the MeterBinders themselves - it might depend on being configured in a certain order relative to other MeterFilters. So, I think we're still up for discussing options if anyone has ideas. |
Please describe the feature request.
In open-telemetry/semantic-conventions#569, OpenTelemetry has made JVM metrics stable. It makes sense to adopt the stable semantic convention for OTLPMeterRegistry to keep in line with the OTEL Semantic Convention.
Additional context
Related links,
The text was updated successfully, but these errors were encountered: