Upgrade to 0.6.6 doesn't keep previous nsclient.ini file

[47pickup]

Hello,

Is there an install option so that the current nsclient.ini file doesn't get lost during an upgrade install? I've tested upgrading from 0.5.2.41 to 0.6.4 and to 0.6.6 and from 0.6.4 to 0.6.6, and in all cases the current nsclient.ini is replaced with a blank version.

Thanks, Dale.

[mickem]

Hello,

0.6.5. should have fixed this issue, but if you have already upgraded to 0.6.4 the config file was unfortunately replaced so if thats the case you need to recreate the config file.
I.e. version 0.5.x -> 0.6.4 -> 0.6.6

If it was a correct config file before you upgraded to version after 0.6.5.
I.e. version 0.5.x -> 0.6.6
if this is the case could you let me know how you upgraded so I can replicate it on my end, I have not seen any issue myself.

// Michael Medin

[47pickup]

Hello,

I just tried another upgrade, on a machine that had 0.6.0.1 and upgraded to 0.6.6. I ran the MSI installer, selected typical, it brought in the correct allowed host, password, and settings. I said install and it ran. Afterwards the nsclient.ini file just has five comment lines and that's it; none of my config that was there before. I'm using the x64 64bit version.

It did prompt me to stop the running process, and I selected stop and restart afterwards. Should I have manually stopped the service before I started the installer?

Thanks, Dale.

[mickem]

Running or not does not matter, the config file is never really locked...
Do you use the visual installer or silen? If so does the "import" (which is showed in the installer have the correct values?)

[47pickup]

I'm running the visual installer. Yes, the import screen shows the correct "allowed hosts", "password", and modules to load settings.

[mickem]

Could you mail [email protected] the log from the installer (dont post it here as it likely contains sensitive information)?

msiexec /l* log.txt /i <msi-file>

[47pickup]

I have captured the log and will send it to you.

Thanks, Dale.

[mickem]

And the nsclient.ini file after this did not contain the keys?

Strange it reads the config correctly and everything seems fine, I will need to run some tests to see if I can reproduce it...

[47pickup]

Yep, the only items in nsclient.ini are 5 comment lines

[47pickup]

[mickem]

After some tinkering I have now figured out what the problem is...
If you upgrade from 0.5 to 0.6 it will delete the config file (apparently considered a major upgrade I think).
Not sure what to do to resolve it as the "problem" if you will is with the "old" installer. I will see if I can add some custom action to copy over the files during upgrade.
This might take a few more days to fix as it is a slightly bigger change...

[47pickup]

One more tidbit of information from my testing, I also see the same behavior if I uninstall any previous version, install 0.6.6, and then try to update to 0.6.7.

Thanks, Dale.

[kcicc]

We actually had this happen to us when 6.4 was released and now 6.7. We keep apps updated through PatchMyPC and never had an issue with nsclient before. However, this time around with the new versions our config file is getting wiped out every time.

It wasn't just going from major versions like 5.2 > 6.4. It happened with 6.6 to 6.7, thought I should share!

[mickem]

This should be fixed by https://github.com/mickem/nscp/releases/tag/0.6.8

Please note that any already deleted config file will not be restored (as it was already deleted) but upgrading from older version will no longer remove the old config

[mickem]

This should be fixed by https://github.com/mickem/nscp/releases/tag/0.6.8

Please note that any already deleted config file will not be restored (as it was already deleted) but upgrading from older version will no longer remove the old config

[47pickup]

I just tested upgrading from 0.5.2.41 to 0.6.8 and also from 0.6.7 to 0.6.8, and in both cases the nsclient.ini file was lost just as before.

Thanks, Dale.

[47pickup]

I did another log on the msi install, and comparing that to the changelog for 0.6.7 -> 0.6.8, I don't see any logMessage saying "Config file found:" or "Backup file:" in the log output from msiexec.

Looking at the changelog from installer_lib.cpp lines 677-679, I'm guessing there should be log messages for finding the old config file and what the backup file is?

Thanks, Dale.

[47pickup]

Doing more digging on the log file from the MSI install, I see where it deletes files before it gets to the "ScheduleWriteConfig" section ....

Action 8:07:57: RemoveFiles. Removing files
RemoveFiles: File: nsclient.log, Directory: C:\Program Files\NSClient++
RemoveFiles: File: boot.ini, Directory: C:\Program Files\NSClient++
RemoveFiles: File: boot.ini, Directory: C:\Program Files\NSClient++
RemoveFiles: File: nsclient.ini, Directory: C:\Program Files\NSClient++
RemoveFiles: File: op5.ini, Directory: C:\Program Files\NSClient++
RemoveFiles: File: nsclient.log, Directory: C:\Program Files\NSClient++
RemoveFiles: File: certificate.pem, Directory: C:\Program Files\NSClient++\security
RemoveFiles: File: ca.pem, Directory: C:\Program Files\NSClient++\security
RemoveFiles: File: Display the NSClient++ online web ui (SSL).lnk, Directory: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\NSClient++
RemoveFiles: File: nscp.exe, Directory: C:\Program Files\NSClient++
RemoveFiles: File: reporter.exe, Directory: C:\Program Files\NSClient++
RemoveFiles: File: check_nrpe.exe, Directory: C:\Program Files\NSClient++
RemoveFiles: File: nsclient.ini, Directory: C:\Program Files\NSClient++\

Action start 8:08:13: ScheduleWriteConfig.
1: installer_lib::ScheduleWriteConfig
1: : NSCP Dumping properties: Before ScheduleWriteConfig
1: : +++ KEY_CONF_SCHEDULER=
1: : +++ KEY_CONF_CHECKS=1
1: : +++ KEY_CONF_NRPE=1
1: : +++ KEY_CONF_NSCA=
1: : +++ KEY_CONF_WEB=
1: : +++ KEY_CONF_NSCLIENT=
1: : +++ KEY_NRPEMODE=SECURE
1: : +++ KEY_CONFIGURATION_TYPE=ini://${shared-path}/nsclient.ini
1: : +++ KEY_CONF_INCLUDES=
1: : +++ KEY_INSTALL_SAMPLE_CONFIG=
1: : +++ KEY_GENERATE_SAMPLE_CONFIG=
1: : +++ KEY_CONF_CAN_CHANGE=1
1: : +++ OP5_SERVER=
1: : +++ OP5_USER=
1: : +++ OP5_PASSWORD=
1: : +++ OP5_HOSTGROUPS=
1: : +++ OP5_CONTACTGROUP=
1: Adding include:

Thanks, Dale.

[mickem]

I am so, so sorry..

I see now that the scheduling change I made on Saturday is missing so I must have done a mistake when I committed the change. I will push a new build ASAP...

[mickem]

I have tried to re construct the config I used over the weekend but alas failed. I have instead created a new solution and then I found that the problem was likely just that it accidentally wrote the config to nsc.ini instead of nsclient.ini.

Anyways I have a new version which I have tested locally that is currently building, it will be done in an hour or so here (feel free to verify): https://github.com/mickem/nscp/actions/runs/13250181343

I will verify the built artifact locally (but that will have to wait till tomorrow) and then push a new release (expected tomorrow evening)...

[47pickup]

Good morning,

Thank you very much for release 0.6.9. I've tested three upgrades, one from 0.5.2.41, one from 0.6.6, and one from 0.6.8 and all three maintained the nsclient.ini file. I'll be doing more upgrades in the near future, so I'll let you know if I see anything else odd, but it looks good!! Thanks again.

Thanks, Dale.

[mickem]

Great, thanks for verifying, and sorry for the SNAFU...