-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in v92: set_child removed #2211
Comments
@vanvugt I did that change because the window preview (middle-click in an app with several windows) didn't work. I tried to revert that using set_child, but either it fails (no window thumbnails are shown in the popup), or directly a javascript error is shown in the log because the widget doesn't have set_child(). The only place where using set_child() seems to work is at line 362, where the "close-button-symbolic" icon is placed over each thumbnail. |
Yes that sounds like what I found when working on the original GNOME 45 bug. Can we check if it's regressed? |
It looks like there's a regression in 6745d8c which reverted the fix of 42ee745.
set_child
should be used in place ofadd_child
to avoid those crashes in GNOME 45.CC @3v1n0 @sergio-costas
The text was updated successfully, but these errors were encountered: