Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in v92: set_child removed #2211

Open
vanvugt opened this issue Apr 29, 2024 · 2 comments
Open

Regression in v92: set_child removed #2211

vanvugt opened this issue Apr 29, 2024 · 2 comments

Comments

@vanvugt
Copy link
Collaborator

vanvugt commented Apr 29, 2024

It looks like there's a regression in 6745d8c which reverted the fix of 42ee745. set_child should be used in place of add_child to avoid those crashes in GNOME 45.

CC @3v1n0 @sergio-costas

@sergio-costas
Copy link
Contributor

@vanvugt I did that change because the window preview (middle-click in an app with several windows) didn't work. I tried to revert that using set_child, but either it fails (no window thumbnails are shown in the popup), or directly a javascript error is shown in the log because the widget doesn't have set_child(). The only place where using set_child() seems to work is at line 362, where the "close-button-symbolic" icon is placed over each thumbnail.

@vanvugt
Copy link
Collaborator Author

vanvugt commented May 14, 2024

The only place where using set_child() seems to work is at line 362, where the "close-button-symbolic" icon is placed over each thumbnail.

Yes that sounds like what I found when working on the original GNOME 45 bug. Can we check if it's regressed?
https://bugs.launchpad.net/bugs/2056506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants