Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate behavior with werkzeug >= 1.0.0 #9

Open
michael-lazar opened this issue Apr 11, 2020 · 1 comment
Open

Investigate behavior with werkzeug >= 1.0.0 #9

michael-lazar opened this issue Apr 11, 2020 · 1 comment

Comments

@michael-lazar
Copy link
Owner

It appears that some recent updates to werkzeug have broken this plugin. I did a bit of digging and most of the relevant changes are around adding support for websockets. It might end up being infeasible to continue monkey-patching gopher compatibility (I hope not though!)

For now, I am going to pin the werkzeug dependency to < 1.0.0 and publish a new release.

@michael-lazar
Copy link
Owner Author

Here's the code in question

https://github.com/pallets/werkzeug/blob/51860032cc780fa4a120b4a3c0457a36bbe91715/src/werkzeug/routing.py#L2177-L2181

If I change this as shown, I can get all of the tests to pass:

        if websocket:
            force_external = True
            url_scheme = "wss" if secure else "ws"
        elif url_scheme in ("http", "https"):
            url_scheme = "https" if secure else "http"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant