Skip to content

Commit 9dc1e4e

Browse files
Merge pull request #17 from abbrev/fix-text-width
Change maximum text width to 69 characters
2 parents a9ecc45 + 4fe0cf4 commit 9dc1e4e

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

demo/demo.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ SECRET_KEY = '%dD.AJN89-+isd?b8ycbDA'
2727
GOPHER_SHOW_STACK_TRACE = True
2828

2929
# Maximum line width for gopher menu pages
30-
GOPHER_WIDTH = 70
30+
GOPHER_WIDTH = 69

flask_gopher/flask_gopher.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class TextFormatter:
5959
Helper methods for applying formatting techniques to gopher menu text.
6060
"""
6161

62-
def __init__(self, default_width=70):
62+
def __init__(self, default_width=69):
6363
self.default_width = default_width
6464

6565
def banner(self, text, ch="=", side="-", width=None):
@@ -379,7 +379,7 @@ class GopherExtension:
379379
</HTML>
380380
"""
381381

382-
DEFAULT_WIDTH = 70
382+
DEFAULT_WIDTH = 69
383383

384384
def __init__(self, app=None, menu_class=GopherMenu, formatter_class=TextFormatter):
385385
self.show_stack_trace = None
@@ -754,7 +754,7 @@ def __init__(
754754
view_name,
755755
url_token="filename",
756756
show_timestamp=False,
757-
width=70,
757+
width=69,
758758
):
759759
"""
760760
Args:

tests/test_flask_gopher.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -489,13 +489,13 @@ def test_isolated_requests(self):
489489

490490
class TestTextFormatter(unittest.TestCase):
491491
def setUp(self):
492-
self.formatter = TextFormatter(default_width=70)
492+
self.formatter = TextFormatter(default_width=69)
493493

494494
def test_banner_normal(self):
495495
output = self.formatter.banner("BANNER")
496496
lines = output.splitlines()
497497
self.assertEqual(len(lines), 3)
498-
self.assertTrue(all(len(line) == 70 for line in lines))
498+
self.assertTrue(all(len(line) == 69 for line in lines))
499499
self.assertEqual(lines[1][0], "-")
500500
self.assertEqual(lines[1][-1], "-")
501501

@@ -514,21 +514,21 @@ def test_banner_custom_ch(self):
514514

515515
def test_banner_no_border(self):
516516
output = self.formatter.banner("BANNER", ch="", side="")
517-
self.assertEqual(output, "BANNER".center(70))
517+
self.assertEqual(output, "BANNER".center(69))
518518

519519
def test_wrap(self):
520520
text = "f" * 100 + "\n" + "g" * 100
521521
output = self.formatter.wrap(text, indent="**")
522522
lines = output.splitlines()
523523
self.assertEqual(len(lines), 4)
524-
self.assertEqual(max(len(line) for line in lines), 70)
524+
self.assertEqual(max(len(line) for line in lines), 69)
525525
self.assertTrue(all(line.startswith("**") for line in lines))
526526

527527
def test_center(self):
528528
text = "line 1\nlonger line 2\n"
529529
output = self.formatter.center(text, fillchar="_")
530530
lines = output.splitlines()
531-
self.assertTrue(all(len(line) == 70 for line in lines))
531+
self.assertTrue(all(len(line) == 69 for line in lines))
532532
self.assertTrue(lines[0].startswith("_"))
533533
self.assertTrue(lines[1].startswith("_"))
534534
self.assertTrue(lines[0].endswith("_"))
@@ -538,7 +538,7 @@ def test_rjust(self):
538538
text = "line 1\nlonger line 2\n"
539539
output = self.formatter.rjust(text, fillchar="_")
540540
lines = output.splitlines()
541-
self.assertTrue(all(len(line) == 70 for line in lines))
541+
self.assertTrue(all(len(line) == 69 for line in lines))
542542
self.assertTrue(lines[0].startswith("_"))
543543
self.assertTrue(lines[1].startswith("_"))
544544
self.assertTrue(lines[0].endswith("_line 1"))
@@ -548,7 +548,7 @@ def test_ljust(self):
548548
text = "line 1\nlonger line 2\n"
549549
output = self.formatter.ljust(text, fillchar="_")
550550
lines = output.splitlines()
551-
self.assertTrue(all(len(line) == 70 for line in lines))
551+
self.assertTrue(all(len(line) == 69 for line in lines))
552552
self.assertTrue(lines[0].startswith("line 1_"))
553553
self.assertTrue(lines[1].startswith("longer line 2_"))
554554
self.assertTrue(lines[0].endswith("_"))
@@ -559,7 +559,7 @@ def test_float_right(self):
559559
right = "right line 1"
560560
output = self.formatter.float_right(left, right, fillchar="_")
561561
lines = output.splitlines()
562-
self.assertTrue(all(len(line) == 70 for line in lines))
562+
self.assertTrue(all(len(line) == 69 for line in lines))
563563
self.assertTrue(lines[0].startswith("left line 1_"))
564564
self.assertTrue(lines[1].startswith("left line 2_"))
565565
self.assertTrue(lines[0].endswith("_right line 1"))
@@ -578,7 +578,7 @@ def test_figlet(self):
578578
output = self.formatter.figlet("foobar", font="alpha")
579579
lines = output.splitlines()
580580
self.assertGreater(len(lines), 1)
581-
self.assertTrue(all(len(line) <= 70 for line in lines))
581+
self.assertTrue(all(len(line) <= 69 for line in lines))
582582

583583
def test_underline(self):
584584
output = self.formatter.underline("Super Duper")

0 commit comments

Comments
 (0)