feat: support injecting globals for supporting platforms that do not have whatwg fetch as globals (e.g. Node.js) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have whatwg fetch as globals (e.g. Node.js)
|
hey @mhart, just wanted to ask again if you are planning to consider this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this library while noticing that
@aws-sdk/s3-clientdoes not work on Cloudflare Workers. (aws/aws-sdk-js-v3#3104)I am writing isomorphic code that should work both on Cloudflare Worker runtimes and Node.js runtimes.
Currently, this library only supports Node.js by polyfilling globals, which is a practice I would love to avoid.
Instead, this PR adds new parameters for passing
fetch,Request,Headers,crypto, andTextEncoderimplementations to theAwsClientandAwsV4Signerconstructors.Related Links:
Closes #22
PR in which I use
@aws-sdk/s3-client(but want to move toaws4fetch) 😇