Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing default seccomp profile? #86

Closed
bduffany opened this issue Apr 4, 2024 · 3 comments
Closed

Missing default seccomp profile? #86

bduffany opened this issue Apr 4, 2024 · 3 comments

Comments

@bduffany
Copy link

bduffany commented Apr 4, 2024

When running podman run --rm --privileged mgoltzsche/podman:4.9.4 podman system info | grep seccompProfile the output is

    seccompProfilePath: ""

but with the official (?) podman image podman run --rm --privileged podman:latest podman system info | grep seccompProfile the output is

    seccompProfilePath: /usr/share/containers/seccomp.json

Does this mean there is no seccomp profile in effect? I read through the podman source code and I couldn't find a hard-coded default so I think it might be relying on this file to exist (might be worth double-checking my reading of the code though!)

@bduffany
Copy link
Author

bduffany commented Apr 4, 2024

nvm, I think the logic here is loading a hard-coded default: https://github.com/containers/podman/blob/036fb1849b90bed53b9b870e1c44da72c64fe81e/pkg/specgen/generate/config_linux_seccomp.go#L59

Missed this on the first pass. Sorry for the noise!

@bduffany bduffany closed this as completed Apr 4, 2024
@mgoltzsche
Copy link
Owner

Hi @bduffany, thanks for finding that difference between the official podman image and this one.
For convenience and parity I am inclined to add the seccomp.json file to this image...

@bduffany
Copy link
Author

bduffany commented Apr 7, 2024

Seems reasonable to me, I will go ahead and re-open the issue

@bduffany bduffany reopened this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants