Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -set_exit_status by default #1093

Open
mcandre opened this issue Oct 31, 2024 · 0 comments
Open

Enable -set_exit_status by default #1093

mcandre opened this issue Oct 31, 2024 · 0 comments

Comments

@mcandre
Copy link

mcandre commented Oct 31, 2024

Is your feature request related to a problem? Please describe.

When adding revive to large, complex workflows such as linter suites or CI/CD jobs, then there is a reasonable expectation that the tool provides meaningful exit codes by default.

Describe the solution you'd like

Enable -set_exit_status by default.

Describe alternatives you've considered

  • Copying and pasting the -set_exit_status flag everywhere is cumbersome and unintuitive.
  • Copying configuration files everywhere is also somewhat cumbersome and unintuitive.

Additional context

Somewhat of a breaking change, in case engineers are already running revive in their CI/CD pipelines. As a precaution, this change would be a good time to cut a new major version, 2.0.0. We can use SemVer to help communicate the new default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant