-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule exported
add checkPublicInterface
option to check documentation in public interface definition
#1002
Comments
…ule - to check public interface method comments
Hi @comdiv, thank you for reporting the issue and opening a PR (I'll check it in the next days) |
… check documentation on public methods on public interfaces (#1003) * [var-naming] handle private uppercased const * FEATURE #1002 - "checkPublicInterface" option for "exported" rule - to check public interface method comments * fix exported #1002 for ast.Ident * fix exported #1002 for ast.Ident 2 * go fmt applyed * #1002 update documentation on `exported` rule * refactor `exported` rule configuration logic * test and review fixes --------- Co-authored-by: fregin <[email protected]>
I see the #1003 was merged, however no release was made since then. Can you please release new version so we can use this feature with GolangCI-Lint? Thank you |
@mgechev, @chavacava, or other collaborators. Do you have any plans for when to release a new version so that we can use this new flag? |
Based on https://github.com/mgechev/revive/releases/tag/v1.4.0 it should be released. |
For now this code is valid:
suggest to add
checkPublicInterface
toexported
rule to check documentation on interface method declaration,so here
SemiCorrect()
has not valid comment, andNonCorrect()
doesn't have it at allThe text was updated successfully, but these errors were encountered: