From dd4c63f252966747a45ec162d756bac09597cf9b Mon Sep 17 00:00:00 2001
From: jmatss <jmatss@kth.se>
Date: Wed, 15 Jun 2022 21:57:24 +0200
Subject: [PATCH] Add tests for nested non-nullable choice members

---
 XmlSchemaClassGenerator.Tests/XmlTests.cs | 83 +++++++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/XmlSchemaClassGenerator.Tests/XmlTests.cs b/XmlSchemaClassGenerator.Tests/XmlTests.cs
index 33549254..21dd017f 100644
--- a/XmlSchemaClassGenerator.Tests/XmlTests.cs
+++ b/XmlSchemaClassGenerator.Tests/XmlTests.cs
@@ -1100,6 +1100,89 @@ public void ChoiceMembersAreNullable()
             Assert.Contains("Opt4Specified", content);
         }
 
+        [Fact]
+        public void NestedElementInChoiceIsNullable()
+        {
+            // Because nullability isn't directly exposed in the generated C#, we use "XXXSpecified" on a value type
+            // as a proxy.
+            const string xsd = @"<?xml version=""1.0"" encoding=""UTF-8""?>
+<xs:schema xmlns:xs=""http://www.w3.org/2001/XMLSchema"">
+  <xs:element name=""Root"">
+    <xs:complexType>
+      <xs:choice>
+        <xs:sequence>
+          <xs:element name=""ElementA"" type=""xs:int""/>
+        </xs:sequence>
+        <xs:group ref=""Group""/>
+      </xs:choice>
+    </xs:complexType>
+  </xs:element>
+
+  <xs:group name=""Group"">
+    <xs:sequence>
+      <xs:element name=""ElementB"" type=""xs:int""/>
+    </xs:sequence>
+  </xs:group>
+</xs:schema>";
+
+            var generator = new Generator
+            {
+                NamespaceProvider = new NamespaceProvider
+                {
+                    GenerateNamespace = key => "Test"
+                }
+            };
+            var contents = ConvertXml(nameof(NestedElementInChoiceIsNullable), xsd, generator);
+            var content = Assert.Single(contents);
+
+            Assert.Contains("ElementASpecified", content);
+            Assert.Contains("ElementBSpecified", content);
+        }
+
+        [Fact]
+        public void OnlyFirstElementOfNestedElementsIsForcedToNullableInChoice()
+        {
+            // Because nullability isn't directly exposed in the generated C#, we use the "RequiredAttribute"
+            // as a proxy.
+            const string xsd = @"<?xml version=""1.0"" encoding=""UTF-8""?>
+<xs:schema xmlns:xs=""http://www.w3.org/2001/XMLSchema"">
+  <xs:element name=""Root"">
+    <xs:complexType>
+      <xs:choice>
+        <xs:element name=""ElementWithChild"">
+          <xs:complexType>
+            <xs:sequence>
+              <xs:element name=""NestedChild"" type=""xs:int""/>
+            </xs:sequence>
+          </xs:complexType>
+        </xs:element>
+      </xs:choice>
+    </xs:complexType>
+  </xs:element>
+</xs:schema>";
+
+            var generator = new Generator
+            {
+                NamespaceProvider = new NamespaceProvider
+                {
+                    GenerateNamespace = key => "Test"
+                }
+            };
+            var contents = ConvertXml(nameof(OnlyFirstElementOfNestedElementsIsForcedToNullableInChoice), xsd, generator).ToArray();
+            var assembly = Compiler.Compile(nameof(OnlyFirstElementOfNestedElementsIsForcedToNullableInChoice), contents);
+
+            var elementWithChildProperty = assembly.GetType("Test.Root")?.GetProperty("ElementWithChild");
+            var nestedChildProperty = assembly.GetType("Test.RootElementWithChild")?.GetProperty("NestedChild");
+            Assert.NotNull(elementWithChildProperty);
+            Assert.NotNull(nestedChildProperty);
+
+            Type requiredType = typeof(System.ComponentModel.DataAnnotations.RequiredAttribute);
+            bool elementWithChildIsRequired = Attribute.GetCustomAttribute(elementWithChildProperty, requiredType) != null;
+            bool nestedChildIsRequired = Attribute.GetCustomAttribute(nestedChildProperty, requiredType) != null;
+            Assert.False(elementWithChildIsRequired);
+            Assert.True(nestedChildIsRequired);
+        }
+
         [Fact]
         public void AssemblyVisibleIsInternalClass()
         {