Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTracker::advance_sequence removes too much data #524

Open
GreaterThanOrEqual opened this issue Feb 11, 2024 · 0 comments
Open

DataTracker::advance_sequence removes too much data #524

GreaterThanOrEqual opened this issue Feb 11, 2024 · 0 comments

Comments

@GreaterThanOrEqual
Copy link

I have a case where there are missing packets in my capture. The original tcp stream was fine. I receive server_out_of_order_callback after the missing packet but it may take a while before I realize that the problem is with capture (I track acks on the client flow). The packets are stored in buffered_payload_. The problem is when I call advance_sequence, the first stored packet in buffered_payload_ is removed. I think if (seq_compare(it->first, seq) <= 0) in advance_sequence should be if (seq_compare(it->first, seq) < 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant