Laravel 10 #181
Laravel 10 #181
Conversation
| protected $transport; | ||
|
|
||
| public function send(string $fromEmail, string $fromName, string $toEmail, string $subject, MessageTrackingOptions $trackingOptions, string $content): string | ||
| { | ||
| $failedRecipients = []; | ||
|
|
||
| // $failedRecipients = []; |
There was a problem hiding this comment.
Is there anyone else that can help out on this?
There was a problem hiding this comment.
It seems it's not possible to get failed recipients. see symfony/symfony#33812
|
|
||
| $encryption = Arr::get($this->config, 'encryption'); | ||
|
|
||
| $scheme = !is_null($encryption) && $encryption === 'tls' |
There was a problem hiding this comment.
I kinda feel like this should just be exposed in the config instead of some behind the scenes magic. Thoughts?
There was a problem hiding this comment.
encryption isn't an explicit config in symfony, so the examples I saw where checking for tls and the port to determine the schema, then mailer is configured only by a dsn string...
|
Thanks for the PR. I have left a few comments. I think we would need https://github.com/mettle/sendportal to be upgraded at the same time if someone is up for tackling that. |
|
@JonoB thanks for checking, today I was evaluating your project to replace one old mailing list I have. I tried to upgrade to latest laravel and submit some fixes. |
|
Closing this as I created a proper branch |
|
How do we track development on the branch. Your fork? |
|
Many thanks! |
I tried to upgrade this package to Laravel 10, migrating SMTP function to Symfony.
I left commented
$failedRecipients = [];as I didn't find a way to get them.Probably by parsing $result as now contains a SentMessage object
Fixes #153 and #167