Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate codebase to ES8/TypeScript? #100

Open
ZeevKatz opened this issue Aug 4, 2020 · 8 comments
Open

Migrate codebase to ES8/TypeScript? #100

ZeevKatz opened this issue Aug 4, 2020 · 8 comments

Comments

@ZeevKatz
Copy link

ZeevKatz commented Aug 4, 2020

What do you think guys about migrating Zdog codebase to ES8/TypeScript? 馃挭
It will improve coding time and let new people that want to contribute this project an easier start point.

@demensky
Copy link

demensky commented Aug 8, 2020

I think this is a good idea. But migrating this codebase to typescript can be more difficult than reimplementing the library. If you want to use it with typescript you can install the definitions.

@ZeevKatz
Copy link
Author

ZeevKatz commented Aug 8, 2020

@demensky My suggestion was not for using Zdog with TypeScript but to improve the codebase and encourage contribution.
I can take the challenge but we鈥檒l need to do it step-by-step and keep a long live branch until we finish, what do you think?

@demensky
Copy link

demensky commented Aug 8, 2020

Let's try.

@ZeevKatz
Copy link
Author

ZeevKatz commented Aug 8, 2020

@demensky Can you please open a new branch for this? (migrate-to-typescript)

@demensky
Copy link

demensky commented Aug 8, 2020

@desandro

@demensky
Copy link

demensky commented Aug 8, 2020

I do not have permission for this repository. I was just creating definitions.

@ZeevKatz
Copy link
Author

@desandro ?

@desandro
Copy link
Member

  1. I'm open to migrating to ES8. This will likely happen in the next major version upgrade
  2. Yes, I should add TypeScript definition at least. But I prefer keeping the source code in vanilla JavaScript that can be run right in the browser without compilation.

I've been taking a break from Metafizzy development. I may evaluate this in 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants