Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saml20-clj.sp.response-test/assertions-test is actually failing #74

Open
escherize opened this issue Feb 14, 2024 · 0 comments
Open

saml20-clj.sp.response-test/assertions-test is actually failing #74

escherize opened this issue Feb 14, 2024 · 0 comments

Comments

@escherize
Copy link

This line: https://github.com/metabase/saml20-clj/blob/master/test/saml20_clj/sp/response_test.clj#L22

Should actually read:

(doseq [{:keys [response], :as response-map} (test/responses)
          :when (not (test/invalid-confirmation-data? response-map))] ;;<-- call the function
)

Functions are truthy, and (not ) is false, so these tests were never run, eek. Because of this, this doseq didn't execute any bodies aka tests weren't being run. I tweaked it locally and there are 2 failing tests there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant