Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Basic theming for React embedding SDK #41947

Open
9 of 10 tasks
heypoom opened this issue Apr 29, 2024 · 0 comments
Open
9 of 10 tasks

[Epic] Basic theming for React embedding SDK #41947

heypoom opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
Embedding/SDK Embedding SDK for React .Epic Feature Implementation or Project .Team/Embedding Type:New Feature

Comments

@heypoom
Copy link
Contributor

heypoom commented Apr 29, 2024

Allow SDK users to customize the appearance of React components in the interactive embedding SDK, by exposing a theme configuration prop to the MetabaseProvider.

We achieve this by converting a subset of Emotion components to use Mantine components from metabase/ui. This would allow a subset of user's themes (e.g. color palette, fonts, base font sizes) to be applied to the embedded components, such as tables, popovers and filters.

In addition, we will expose custom theme configurations for users to be able to customize specific theme options, which is then merged/injected into target component's styles. This epic focuses on basic theming to match the SDK user's app branding, such as color palette, base font sizes, font family and line height.

Links

Implementation Plan

Milestone 1

Expose theme configuration to MetabaseProvider

  1. heypoom
  2. heypoom
  3. WiNloSt

Milestone 2

Milestone 3

Basic theming for interactive questions

  1. deniskaber
@heypoom heypoom added the .Epic Feature Implementation or Project label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/SDK Embedding SDK for React .Epic Feature Implementation or Project .Team/Embedding Type:New Feature
Projects
None yet
Development

No branches or pull requests

3 participants