Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#bug; QiDao data fixes #2409

Open
melotik opened this issue Oct 26, 2023 · 2 comments · May be fixed by #2440
Open

#bug; QiDao data fixes #2409

melotik opened this issue Oct 26, 2023 · 2 comments · May be fixed by #2440
Assignees
@dhruv-chauhan
Labels
bug Something isn't working p0 high priority

Comments

@melotik
Copy link
Contributor

melotik commented Oct 26, 2023

Describe the bug
There was some data that was noticed to be incorrect on QiDao subgraphs, specifically ETH, ARB, OP (but not limited to those)

The issues we have noticed:

  • There have been new vaults since the subgraph was last updated, so any new vaults need to be added to the config
  • There may be pricing issues (this is unknown), but worth a look at this price on a yearn LINK vault (~$6 on the subgraph, but $LINK is $11 rn)

@ishraq8 or @bye43 for QAing the data. We will re-evaluate to see if this has solved the issues. Or if you notice any other issues while fixing! Thanks
@melotik melotik added bug Something isn't working p0 high priority labels Oct 26, 2023
@melotik
Copy link
Contributor Author

melotik commented Nov 7, 2023 •
edited

Updates:

  • stale prices from vaults not being interacted with on a regular basis -> looking to increase frequency of updates across the subgraph
  • Investigating how we calculate revenue to catch any differences: https://docs.google.com/document/d/1NC09r701nfiff4vmqDmle_0BINCyvViauCiYeE54YmE/edit?usp=sharing
  • Here is the vault info for all of the vaults
  • Need to add these networks:
    • base, metis, moonbeam
  • No longer supporting fantom, harmony, moonriver
  • Full support is: Ethereum, Base, Optimism, Metis, Avalanche, BSC, Gnosis Chain, Polygon, Arbitrum, Moonbeam

cc @dhruv-chauhan

@bye43
Copy link
Contributor

bye43 commented Nov 14, 2023

Will make revenue changes, fix the stale pricing issue, add base, and missing vaults

@melotik melotik linked a pull request Dec 14, 2023 that will close this issue
feat(#major); qidao; rewrite qidao subgraph #2440
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruv-chauhan dhruv-chauhan

Labels
bug Something isn't working p0 high priority
Projects
Subgraph Development
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#major); qidao; rewrite qidao subgraph dhruv-chauhan/subgraphs
3 participants
@dhruv-chauhan @melotik @bye43