From 7c9bd02b5cd3085ea5c1df63607d6556ebed6e67 Mon Sep 17 00:00:00 2001
From: tushar-os <tushar_s@apple.com>
Date: Tue, 1 Oct 2019 13:53:00 -0700
Subject: [PATCH] logging for chronos with log rotation support.

---
 bin/start-chronos.bash |  2 +-
 log4j.properties       | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 log4j.properties

diff --git a/bin/start-chronos.bash b/bin/start-chronos.bash
index 61d9323f9..30a08cec5 100755
--- a/bin/start-chronos.bash
+++ b/bin/start-chronos.bash
@@ -30,7 +30,7 @@ if [ "${1:-absent}" == "absent" ] || [ "${1:0:1}" == '-' ]; then
     echo "Starting Zookeeer.."
     service zookeeper start
   fi
-  set -- java -Xmx"$heap" -Xms"$heap" -cp "${jar_files[0]}" \
+  set -- java -Xmx"$heap" -Xms"$heap" -cp "${jar_files[0]}" -Dlog4j.configuration=file:$chronos_home/log4j.properties \
      org.apache.mesos.chronos.scheduler.Main \
      "${flags[@]}"
 fi
diff --git a/log4j.properties b/log4j.properties
new file mode 100644
index 000000000..07434169e
--- /dev/null
+++ b/log4j.properties
@@ -0,0 +1,28 @@
+log4j.rootLogger=INFO, CONSOLE, ROLLINGFILE
+
+log4j.logger.org.apache.mesos.chronos.scheduler.Main=INFO
+log4j.logger.org.apache.mesos.chronos.scheduler.config=INFO
+log4j.logger.org.apache.mesos.chronos.scheduler.jobs.JobScheduler=INFO
+log4j.logger.org.apache.mesos.chronos.scheduler.jobs.ScheduledTask=INFO
+log4j.logger.org.apache.mesos.chronos.scheduler.jobs.TaskManager=INFO
+log4j.logger.org.apache.mesos.chronos.scheduler.jobs.stats.JobStats=INFO
+#
+log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
+log4j.appender.CONSOLE.Threshold=INFO
+log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout
+log4j.appender.CONSOLE.layout.ConversionPattern=[%d] %p %m (%c:%L)%n
+
+#
+# Add ROLLINGFILE to rootLogger to get log file output
+#    Log DEBUG level and above messages to a log file
+log4j.appender.ROLLINGFILE=org.apache.log4j.RollingFileAppender
+log4j.appender.ROLLINGFILE.Threshold=INFO
+log4j.appender.ROLLINGFILE.File=/tmp/chronos/chronos_docker.log
+
+# Max log file size of 10MB
+log4j.appender.ROLLINGFILE.MaxFileSize=10MB
+# uncomment the next line to limit number of backup files
+log4j.appender.ROLLINGFILE.MaxBackupIndex=2
+
+log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
+log4j.appender.ROLLINGFILE.layout.ConversionPattern=[%d] %p %m (%c:%L)%n