default_options in subprojects override commandline options

[lb90]

If I run meson setup --optimization=0 and a subproject has

project('mylib', 'c',
        default_options: ['optimization=3'])

Then the subproject is built with /O3.

Minimal sample: meson-issue.zip

[bonzini]

For 1.8.3, please look at branch fix14690-1.8 of https://github.com/bonzini/meson.

Several of the cleanups that went into 1.9 only actually help a lot in fixing this bug.

[bonzini]

In addition to the unit tests, I tried adding assert(get_option('optimization') == '0') to the test case; it fails with 1.8.1 and master, and works with my branches.

[lb90]

I confirm it's working, thanks a lot!

[bonzini]

Fixing this will break other scenario such as test common/223 ersubproject options.

I think it's the right thing to do to make machine files and command line options override subproject() and project(), but this is a very messy situation.

I am not sure if leaving it as is in 1.8 and only fixing in 1.9 is going to be better or worse. Ideally not many people are using -Ddefault_library or similar, and not many people are using default_options with global options, and even fewer people are expecting the combo to work. I have almost gotten everything to work, but I really need help figuring out how bad the situation is.

[bonzini]

@lb90 sorry for the stupid question but I'm exhausted: is this a regression from 1.7 to 1.8?

[lb90]

Hi @bonzini,

Yes, that seems to be a regression from 1.7. The test case attached above works fine with Meson 1.7.2, i.e setting up a build dir with -Doptimization=0 both projects are built with Od. Meson from master instead builds the main project with Od and the subproject with O3.

I believe that started happening due to the changes in #14251