Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA "Push commit to schema registry" is failing since october #648

Open
KomelT opened this issue Jan 20, 2025 · 5 comments
Open

GA "Push commit to schema registry" is failing since october #648

KomelT opened this issue Jan 20, 2025 · 5 comments
Assignees

Comments

@KomelT
Copy link
Member

KomelT commented Jan 20, 2025

GA "Push commit to schema registry" has been failing since October and new protobuf versions aren't published.

Image

@sachaw
Copy link
Member

sachaw commented Jan 21, 2025

We can stop publishing to bsr as we aren't using any code generated from there anymore.

@KomelT
Copy link
Member Author

KomelT commented Jan 21, 2025

Oh, I see. I thought Web UI was using protobuf definitions from there, but it inherits them from @meshtastic/js. The JS library gets protobuf definitions from https://jsr.io/@meshtastic/protobufs.

I hope I am not wrong again.

@sachaw
Copy link
Member

sachaw commented Jan 22, 2025

Yeah, the protobuf and main library is being published to JSR
A major advantage of that is having a less complicated .npmrc setup for projects that consume the protobufs as a direct or indirect dependency

@KomelT
Copy link
Member Author

KomelT commented Jan 23, 2025

Ha, interesting. The JSR looks like it is platform-specific (JS and TS). Buf supports Swift, ts, js, python, go, c, rust, scala, and more. Isn't this like a downgrade? I took a look and saw that .npmrc contains only one line. My friend likes to do custom stuff with Meshtastic and GO; after that, he would need to build custom protobuf.

@KomelT
Copy link
Member Author

KomelT commented Jan 24, 2025

In any way. The current version of protobuf on JSR is 2.5.9. The latest protobuf version in the repository is 2.5.19. It might be time to update so we can add new features to the web UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants