Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise GPS probe code - one message per family #5193

Open
fifieldt opened this issue Oct 31, 2024 · 3 comments · May be fixed by #6114
Open

Optimise GPS probe code - one message per family #5193

fifieldt opened this issue Oct 31, 2024 · 3 comments · May be fixed by #6114
Labels
good first issue Good for newcomers help wanted Extra attention is needed low-priority Possibly something we'll consider in the future but doesn't serve the core use-cases or problematic pinned Exclude from stale processing

Comments

@fifieldt
Copy link
Contributor

fifieldt commented Oct 31, 2024 •
edited
Loading

In the GPS probe code (

firmware/src/gps/GPS.cpp

Line 1137 in aae346a

PROBE_SIMPLE("UC6580", "$PDTINFO", "UC6580", GNSS_MODEL_UC6580, 500);
), we write commands on the serial line and determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command, but return different results (eg AG3335 and AG3332 both use $PAIR021*39). Currently we run the command once per GPS. Instead we should run each command only once per family, record the result, and select the GNSS MODEL based on the result.

This will mean probing takes a shorter time.
@fifieldt fifieldt added help wanted Extra attention is needed good first issue Good for newcomers low-priority Possibly something we'll consider in the future but doesn't serve the core use-cases or problematic labels Oct 31, 2024
@absolut3ego
Copy link

can you assign this to me?

@fifieldt
Copy link
Contributor Author

fifieldt commented Nov 3, 2024 •
edited
Loading

Welcome to Meshtastic, we're happy to have you!

One way I thought about implementing this was to change the PROBE_SIMPLE macro.

At the end, save the command we sent as a variable (lastcmd = TOWRITE). Then, at the start, check if TOWRITE == lastcmd and perform the check of the buffer from last time there. Would require changing GPS::getACK so that it can handle returning the buffer or accepting a pointer to a buffer.

Let us know if you need any pointers!

@absolut3ego
Copy link

Hi @fifieldt,

I have a few questions. First, can you tell me how the PROBE_SIMPLE macro currently works? To make sure that my modification can work correctly with your project. Second, how do you want me to solve this issue? As I initially understood, I need to add something to store the results of each GPS family, so that I can call a family many times without having to re-execute the PROBE_SIMPLE macro. But according to your suggestion, I understand it in a different way, which is to save the last command. If the next command matches it, I will get the result that was just called to return. Can you explain this issue more clearly? I need to understand clearly to be able to have the correct solution.

absolut3ego added a commit to absolut3ego/firmware that referenced this issue Nov 4, 2024
@absolut3ego
Fix issue meshtastic#5193: Optimise GPS probe code - one message per …
eb3df6a 
…family
thebentern added a commit to absolut3ego/firmware that referenced this issue Nov 4, 2024
@thebentern
Merge branch 'master' into fix-issue-meshtastic#5193
351926d
jp-bennett added a commit to absolut3ego/firmware that referenced this issue Nov 13, 2024
@jp-bennett
Merge branch 'master' into fix-issue-meshtastic#5193
2b3065b
fifieldt pushed a commit to absolut3ego/firmware that referenced this issue Nov 14, 2024
@absolut3ego @fifieldt
Fix issue meshtastic#5193: Optimise GPS probe code - one message per …
a7946b5 
…family
@github-actions github-actions bot added the Stale label Jan 3, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@fifieldt fifieldt reopened this Feb 21, 2025
@fifieldt fifieldt added pinned Exclude from stale processing and removed Stale labels Feb 21, 2025
fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Feb 21, 2025
@fifieldt
Only call GPS Probe commands once per family
70bb4e8 
In the GPS probe code we write commands on the serial line and
 determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command,
 but return different results (eg AG3335 and AG3332 both use $PAIR021*39).
Currently we run the command once per GPS. Instead we should run each
command only once per family, record the result, and select the GNSS MODEL
 based on the result, which is what this patch does.

Before the change, we put 12 commands on the serial bus.
Now we only put 6.

This should markedly improve the speed and reliability of GPS detection.

Fixes meshtastic#5193
@fifieldt fifieldt linked a pull request Feb 21, 2025 that will close this issue
Open
fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Feb 21, 2025
@fifieldt
Only call GPS Probe commands once per family
bd58b88 
In the GPS probe code we write commands on the serial line and
 determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command,
 but return different results (eg AG3335 and AG3332 both use $PAIR021*39).
Currently we run the command once per GPS. Instead we should run each
command only once per family, record the result, and select the GNSS MODEL
 based on the result, which is what this patch does.

Before the change, we put 12 commands on the serial bus.
Now we only put 6.

This should markedly improve the speed and reliability of GPS detection.

Fixes meshtastic#5193
fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Feb 21, 2025
@fifieldt
Only call GPS Probe commands once per family
7f981ab 
In the GPS probe code we write commands on the serial line and
 determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command,
 but return different results (eg AG3335 and AG3332 both use $PAIR021*39).
Currently we run the command once per GPS. Instead we should run each
command only once per family, record the result, and select the GNSS MODEL
 based on the result, which is what this patch does.

Before the change, we put 12 commands on the serial bus.
Now we only put 6.

This should markedly improve the speed and reliability of GPS detection.

Fixes meshtastic#5193
fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Feb 21, 2025
@fifieldt
Only call GPS Probe commands once per family
205431b 
In the GPS probe code we write commands on the serial line and
 determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command,
 but return different results (eg AG3335 and AG3332 both use $PAIR021*39).
Currently we run the command once per GPS. Instead we should run each
command only once per family, record the result, and select the GNSS MODEL
 based on the result, which is what this patch does.

Before the change, we put 12 commands on the serial bus.
Now we only put 6.

This should markedly improve the speed and reliability of GPS detection.

Fixes meshtastic#5193
fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Feb 21, 2025
@fifieldt
Only call GPS Probe commands once per family
6f085c3 
In the GPS probe code we write commands on the serial line and
 determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command,
 but return different results (eg AG3335 and AG3332 both use $PAIR021*39).
Currently we run the command once per GPS. Instead we should run each
command only once per family, record the result, and select the GNSS MODEL
 based on the result, which is what this patch does.

Before the change, we put 12 commands on the serial bus.
Now we only put 6.

This should markedly improve the speed and reliability of GPS detection.

Fixes meshtastic#5193
fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Feb 21, 2025
@fifieldt
Only call GPS Probe commands once per family
a810943 
In the GPS probe code we write commands on the serial line and
 determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command,
 but return different results (eg AG3335 and AG3332 both use $PAIR021*39).
Currently we run the command once per GPS. Instead we should run each
command only once per family, record the result, and select the GNSS MODEL
 based on the result, which is what this patch does.

Before the change, we put 12 commands on the serial bus.
Now we only put 6.

This should markedly improve the speed and reliability of GPS detection.

Fixes meshtastic#5193
fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Feb 21, 2025
@fifieldt
Only call GPS Probe commands once per family
d8283b8 
In the GPS probe code we write commands on the serial line and
 determine which GPS we have based on the result.

GPS units in the same family sometimes use the same command,
 but return different results (eg AG3335 and AG3332 both use $PAIR021*39).
Currently we run the command once per GPS. Instead we should run each
command only once per family, record the result, and select the GNSS MODEL
 based on the result, which is what this patch does.

Before the change, we put 12 commands on the serial bus.
Now we only put 6.

This should markedly improve the speed and reliability of GPS detection.

Fixes meshtastic#5193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed low-priority Possibly something we'll consider in the future but doesn't serve the core use-cases or problematic pinned Exclude from stale processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only call GPS Probe commands once per family fifieldt/meshtastic-firmware
2 participants
@fifieldt @absolut3ego