🐞 [Bug]: Device metrics graph drawing outside chart boundaries

[ccw-]

Before submitting

• I have searched existing issues to make sure this bug hasn't already been reported
• I have updated to the latest version of the software to verify the issue still exists

Firmware Version

2.7.15 (behavior independent of firmware version)

What did you do?

Display the device metrics graphs for a connected node.

Expected Behavior

Graphs draw within the boundaries of the plot axes.

Current Behavior

When given bad data by the connected node (in this case a Heltec Meshsolar), the app will draw the state of charge graph outside the boundaries of the plot, eg all the way to the top edge of the display. Layer order is such that the graph draws under the plot title and other text farther up the window, but over the background.

Participation

• I am willing to submit a pull request for this issue.

Additional comments

Obviously, the node should not be intermittently reporting 65V or "powered" when it isn't, so there's a separate bug contributing to the behavior, the issue drawing the plot with bad input seems orthogonal.

Code of Conduct

• I agree to follow this project's Code of Conduct

ETA: I haven't written any swift before, but I've checked willing to submit a pull request in the hopes that this might be an easy to spot issue if one is looking for it. Any pointers to where I can find the plotting code would be welcome. Not familiar with the organization of iOS apps.

[ccw-]

I guess on another look, the behavior is a little more complicated than I thought. When the bad input is an invalid large number, a percentage derived from 65V, it draws a point at the top of the axis. When it's an invalid low number, it draws no point. It's when the device reports powered that it draws off the edge of the chart.

[ccw-]

Apologies again, I was confusing myself with the cursor. Invalid voltages don't plot at all or somehow result in correct percentage calculations it's just how "powered" is being handled.

Additional screenshot to show the behavior for one of the 65v data points.