Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Remove onboard command from mesheryctl pattern commands #10886

Open
singh1203 opened this issue May 7, 2024 · 3 comments · May be fixed by #10929
Open

[mesheryctl] Remove onboard command from mesheryctl pattern commands #10886

singh1203 opened this issue May 7, 2024 · 3 comments · May be fixed by #10929
Assignees
Labels
component/mesheryctl CLI for Meshery issue/willfix This issue will be worked on kind/bug Something isn't working language/go Issues or pull requests that use Golang

Comments

@singh1203
Copy link
Contributor

See mesheryctl Command Tracker for current status of commands.

Current Behavior

The 'onboard' command is redundant with the 'import' and 'apply' commands.
Users can already achieve the same outcome by using import to import the pattern and apply to deploy it.

Desired Behavior

Removing onboard will simplify the mesheryctl pattern command set.

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v
  • Platform: Docker Kubernetes

Contributor Guides and Handbook

@singh1203 singh1203 added component/mesheryctl CLI for Meshery kind/bug Something isn't working language/go Issues or pull requests that use Golang labels May 7, 2024
Copy link

github-actions bot commented May 7, 2024

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@singh1203
Copy link
Contributor Author

@Yashsharma1911 please assign.

@leecalcote leecalcote added the issue/willfix This issue will be worked on label May 10, 2024
@leecalcote
Copy link
Member

Thanks, @singh1203 👍

singh1203 added a commit to singh1203/meshery that referenced this issue May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery issue/willfix This issue will be worked on kind/bug Something isn't working language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants