Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mesheryctl] Failing Unit test at System package level #10758

Closed
singh1203 opened this issue Apr 22, 2024 · 2 comments
Closed

[mesheryctl] Failing Unit test at System package level #10758

singh1203 opened this issue Apr 22, 2024 · 2 comments
Labels
component/mesheryctl CLI for Meshery kind/bug Something isn't working language/go Issues or pull requests that use Golang

Comments

@singh1203
Copy link
Contributor

See mesheryctl Command Tracker for current status of commands.

Current Behavior

For reference, mesheryctl system package unit tests are failing as you can find in link
https://github.com/meshery/meshery/actions/runs/8774489387/job/24075741293?pr=10703

Desired Behavior

We need regular updates of golden files especially with ModelCmd tests

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v
  • Platform: Docker Kubernetes

Contributor Guides and Handbook
@singh1203 singh1203 added component/mesheryctl CLI for Meshery kind/bug Something isn't working language/go Issues or pull requests that use Golang labels Apr 22, 2024
@github-actions GitHub Actions
Copy link

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@singh1203 singh1203 changed the title [mesheryctl] Failing Unit test at Sytem package level [mesheryctl] Failing Unit test at System package level May 2, 2024
This was referenced May 2, 2024
Closed
Closed
@singh1203
Copy link
Contributor Author

Closing! It has already been resolved by #11002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/mesheryctl CLI for Meshery kind/bug Something isn't working language/go Issues or pull requests that use Golang
Projects
None yet
Milestone
No milestone
1 participant
@singh1203