Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from MeshModel to Model #153

Closed
leecalcote opened this issue Feb 28, 2024 · 4 comments
Closed

Move from MeshModel to Model #153

leecalcote opened this issue Feb 28, 2024 · 4 comments
Assignees
@gyohuangxin
Labels
good first issue Good for newcomers issue/stale Issue has not had any activity for an extended period of time kind/chore Necessary task
Milestone
v0.8.0

Comments

@leecalcote
Copy link
Member 

          We're in need of having `RegisterMeshModelComponents` changed to `RegisterMeshModelComponents` inside of the Meshery Adapter Library. Let's do what we can to get away from `MeshModel` over to `Model`.

Originally posted by @leecalcote in meshery/meshery-nighthawk#46 (comment)
@leecalcote
Copy link
Member Author

@gyohuangxin I wonder if you might be able to undertake this. Be aware that once the change is made and a new version of the library released, each adapter will need a small update. // @MUzairS15

@leecalcote leecalcote added good first issue Good for newcomers kind/chore Necessary task labels Feb 28, 2024
@leecalcote leecalcote added this to the v0.8.0 milestone Feb 28, 2024
@gyohuangxin
Copy link
Member

@leecalcote Yes, @MUzairS15 mention it before. I can take this.

@gyohuangxin gyohuangxin mentioned this issue Feb 28, 2024
Closed
@stale Stale
Copy link

stale bot commented Apr 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 13, 2024
@stale Stale
Copy link

stale bot commented Apr 27, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyohuangxin gyohuangxin

Labels
good first issue Good for newcomers issue/stale Issue has not had any activity for an extended period of time kind/chore Necessary task
Projects
Meshery Current Release Train
Status: Done
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@leecalcote @gyohuangxin