implement deleting artist aliases

Author: mertvn

EMQ/Client/Components/EditArtistComponent.razor

@@ -9,6 +9,7 @@
 @using EMQ.Shared.MusicBrainz.Business
 @using EMQ.Shared.VNDB.Business
 @inject HttpClient _client
+@inject IJSRuntime _jsRuntime
 
 <div style="border: 1px black solid; padding: 10px; max-width: 1400px;">
     @if (IsNew)
@@ -28,7 +29,7 @@
             <summary>Guidelines for editing artists</summary>
             <ul>
                 <li>Follow VNDB's guidelines on name order and romanization.</li>
-                <li>Deleting aliases is currently not supported.</li>
+                <li>Ask a mod if you want to delete an existing alias.</li>
             </ul>
             <br/>
         </details>
@@ -67,6 +68,12 @@
                     int indexCopy = index;
                     <div style="border: 1px black solid; padding: 10px;">
                         <span style="display: inline-block; cursor: pointer; margin-right: 4px;" @onclick="@(async () => await RemoveAlias(indexCopy))">🗑</span>
+                        @if (AuthStuff.HasPermission(ClientState.Session, PermissionKind.ReviewEdit))
+                        {
+                            <button type="button" class="btn btn-danger" @onclick="@(async () => { await Onclick_DeleteAAFromDb(Artist.Id, alias.ArtistAliasId); })">
+                                Delete artist alias from the database
+                            </button>
+                        }
                         <br/>
 
                         <label style="padding: 4px;">
@@ -628,4 +635,25 @@
         Artist = artist;
     }
 
+    private async Task Onclick_DeleteAAFromDb(int aId, int aaId)
+    {
+        bool confirmed = await _jsRuntime.InvokeAsync<bool>("confirm",
+            "Songs linked to this alias will be transferred over to the primary alias. This action is IRREVERSIBLE. Are you sure you want to delete this alias?");
+        if (!confirmed)
+        {
+            return;
+        }
+
+        var req = new SongArtist() { Id = aId, Titles = new List<Title>() { new() { ArtistAliasId = aaId } } };
+        HttpResponseMessage res = await _client.PostAsJsonAsync("Mod/DeleteArtistAlias", req);
+        if (res.IsSuccessStatusCode)
+        {
+            Artist.Titles.RemoveAll(x => x.ArtistAliasId == aaId);
+        }
+        else
+        {
+            await _jsRuntime.InvokeVoidAsync("alert",
+                $"Error: {res.StatusCode:D} {res.StatusCode} {await res.Content.ReadAsStringAsync()}");
+        }
+    }
 }

EMQ/Server/Controllers/ModController.cs

@@ -297,4 +297,24 @@ public async Task<ActionResult> EditUser(ResGetPublicUserInfo req)
         await transactionAuth.CommitAsync();
         return Ok();
     }
+
+    [CustomAuthorize(PermissionKind.ReviewEdit)]
+    [HttpPost]
+    [Route("DeleteArtistAlias")]
+    public async Task<ActionResult> DeleteArtistAlias(SongArtist req)
+    {
+        if (ServerState.IsServerReadOnly)
+        {
+            return Unauthorized();
+        }
+
+        var session = AuthStuff.GetSession(HttpContext.Items);
+        if (session is null)
+        {
+            return Unauthorized();
+        }
+
+        bool success = await DbManager.DeleteArtistAlias(req.Id, req.Titles.Single().ArtistAliasId);
+        return success ? Ok() : StatusCode(500);
+    }
 }

EMQ/Server/Db/DbManager.cs

@@ -1610,6 +1610,7 @@ await connection.InsertAsync(
             }
 
             // todo delete aliases that exist in the db but not in the argument -- might be easier to use UpsertList
+            // actually don't because we will have erroneous deletes when editing
             aaIds.Add(aaId);
         }
 
@@ -1643,6 +1644,30 @@ await connection.InsertAsync(
         return (aId, aaIds);
     }
 
+    public static async Task<bool> DeleteArtistAlias(int aId, int aaId)
+    {
+        await using var connection = new NpgsqlConnection(ConnectionHelper.GetConnectionString());
+        await connection.OpenAsync();
+        await using var transaction = await connection.BeginTransactionAsync();
+
+        int newAaId = await connection.ExecuteScalarAsync<int>(
+            "select id from artist_alias where artist_id = @aId AND is_main_name",
+            new { aId }, transaction);
+        if (newAaId > 0)
+        {
+            await connection.ExecuteAsync(
+                "UPDATE artist_music am SET artist_alias_id = @newAaId where artist_alias_id = @aaId",
+                new { aaId, newAaId }, transaction);
+            if (await connection.DeleteAsync(new ArtistAlias() { id = aaId }, transaction))
+            {
+                await transaction.CommitAsync();
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     // todo take QuizSettings as a required param instead of all this crap
     public static async Task<List<Song>> GetRandomSongs(int numSongs, bool duplicates,
         List<string>? validSources = null, QuizFilters? filters = null, bool printSql = false,

Tests/EntryPoints.cs

@@ -2696,4 +2696,23 @@ public async Task InsertCALFromMusicBrainz()
             await Task.Delay(TimeSpan.FromSeconds(10));
         }
     }
+
+    [Test, Explicit]
+    public async Task ListArtistAliasesThatDifferOnlyInIsMainAliasFlag()
+    {
+        await using var connection = new NpgsqlConnection(ConnectionHelper.GetConnectionString());
+        var aas = (await connection.GetListAsync<ArtistAlias>()).ToArray();
+        foreach (ArtistAlias aa in aas)
+        {
+            var dup = aas.Where(x =>
+                x.artist_id == aa.artist_id &&
+                x.latin_alias == aa.latin_alias &&
+                x.non_latin_alias == aa.non_latin_alias).ToList();
+            if (dup.Count > 1)
+            {
+                Console.WriteLine(JsonSerializer.Serialize(dup, Utils.JsoIndented));
+                Console.WriteLine("-------------------------------------------------------");
+            }
+        }
+    }
 }