-
Notifications
You must be signed in to change notification settings - Fork 64
NA: Use relative path for NA plugin search #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
883a833
to
8f30b7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few comments but looks good to me otherwise, thanks!
See also this warning from the CI: https://cdash.mercury.daos.io/viewBuildError.php?type=1&buildid=2910
|
hopefully it's fixed with the cast |
Calculate relative path at build time and use it at runtime to find the plugin directory Signed-off-by: Jeff Olivier <[email protected]>
Calculate relative path at build time and use it at runtime to find the plugin directory