Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of underscores and camelCase in served JSON #45

Open
russ3llc opened this issue Sep 19, 2022 · 4 comments
Open

Inconsistent use of underscores and camelCase in served JSON #45

russ3llc opened this issue Sep 19, 2022 · 4 comments

Comments

@russ3llc
Copy link

The hosted JSON at http://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/items and http://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/items.json has inconsistent use of underscores and camelCase in keys.
E.g. Some items use "attackDamage" while others use "attack_damage".

This was acknowledged in the code in Issue #29, but was actually resolved from what I can tell. However, the served JSON still has those inconsistencies.

I used a Python script to standardize this for the combined items JSON.
Script: https://1drv.ms/u/s!Ak6LaqWhKRfWhKJlkXwLAB4XtlREYg?e=I1KZKA
New JSON: https://1drv.ms/u/s!Ak6LaqWhKRfWhKJnw9VEN0oabXqIDA?e=6Ym7Iv

@russ3llc
Copy link
Author

Oh, and for some reason Equinox (7023) Ornn isn't listed as a "requiredAlly".

@jjmaldonis
Copy link
Member

Making this change would likely break any apps that are using this data. We will fix this the next time there are major breaking changings to the format of the JSON file.

@russ3llc
Copy link
Author

russ3llc commented Oct 8, 2022

Makes sense. Thanks!

@russ3llc russ3llc closed this as completed Oct 8, 2022
@jjmaldonis
Copy link
Member

I'm going to keep this open so I don't forget :)

@jjmaldonis jjmaldonis reopened this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants