make it better

Author: mennatnaga

avoiding_common_attacks.md

@@ -1,5 +1,8 @@
-1) Using Specific Compiler Pragma: SWC-103	
-    using pragma solidity ^0.8.3;
+# Contract security measures
 
-2) Proper Use of Require and Revert: SWC-123	
-    using Require in SwapTokens Contract to check ETH and tokens balance before any transfer and Revert to revert back ETH of invalid txns.
+1) Floating Pragma: SWC-103	
+   Using specific compiler pragma 0.8.3 in contracts to avoid accidental bug inclusion through outdated compiler versions.
+
+
+2) Requirement Violation: SWC-123	
+    Using Require in SwapTokens Contract to check ETH and tokens balance before any transfer and using Revert to revert back ETH of invalid txns.

contracts/Migrations.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.3;
+pragma solidity 0.8.3;
 
 contract Migrations {
   address public owner;

contracts/SwapTokens.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.3;
+pragma solidity 0.8.3;
 
 
 // Using dependency-injection to call other contracts' functions.

contracts/TokenA.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.3;
+pragma solidity 0.8.3;
 
 import "@openzeppelin/contracts/token/ERC20/ERC20.sol";
 

contracts/TokenB.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.3;
+pragma solidity 0.8.3;
 
 import "@openzeppelin/contracts/token/ERC20/ERC20.sol";
 

deployed_address.txt

@@ -1,7 +1,7 @@
 Testnet: Rinkeby
-SwapTokens Contract Address: 0xF2e6d2CdF5749e20aE15F48E4070bc584C8D7F69
-TokenA Contract Address: 0x8FBdB5Da8a38D5c799Ad353c53F5C0744c5F6E0B
-TokenB Contract Address: 0xD6697E4fF3c5c1aeb6f30DB712c8981ACbCDCbBe
-Migrations Contract Address: 0x24F6b3921B4Ae67f6266f886E5B0c4bdAA0fF3AD
+SwapTokens Contract Address: 0x2522B1aAeA8a12cFe82E65CF7B07cc61eFD893DC
+TokenA Contract Address: 0xb6409B711d511A7db64cCBDa2Eca452AAad58ee2
+TokenB Contract Address: 0x817E0B7b325Dd3b4EC40bF5895d4f51b01800Da1
+Migrations Contract Address: 0x233937ADdE8e3B644fc41AEFEd9ccc1609f9E7A3
 Deployer Public Address: 0x4bb52fF3e053d127265A8A8dDf9Dc291fcF04aF0
-Final cost: 0.009676172557372237 ETH
+Final cost: 0.00967614254761444 ETH

design_pattern_decisions.md

@@ -1,10 +1,10 @@
+# Design patterns used:
+
 1)Inter-Contract Execution:
     SwapTokens Contract calls TokenA and TokenB functions by importing them (aka dependency injection).
 
 
 2) Inheritance and Interfaces: 
         TokenA and TokenB contracts are ERC20 tokens, they inherit from @openzeppelin/contracts/token/ERC20/ERC20.sol contract.
 
-3) Access Control Design Patterns: 
-    SwapTokens contract uses Ownable access control.
 

truffle-config.js

@@ -22,7 +22,8 @@ module.exports = {
         return new HDWalletProvider(MNEMONIC, API_URL)
       },
       network_id: 4,
-      gas: 4000000 //4M is the max
+      gas: 4000000, //4M is the max
+      
     }
 
   },