You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The meltano test CLI uses plugin commands to run tests for one or more plugins. However It's not working great at the moment for taps because Meltano doesn't know that it also needs to pass other options, like --config, so it fails if config is required.
Proposal
Add a new boolean pass_plugin_args field to the Command object.
Update PluginInvoker.exec_args to call self.plugin.exec_args, if command_config.pass_plugin_args is true.
Feature scope
CLI (options, error messages, logging, etc.)
Description
Problem
The
meltano test
CLI uses plugin commands to run tests for one or more plugins. However It's not working great at the moment for taps because Meltano doesn't know that it also needs to pass other options, like--config
, so it fails if config is required.Proposal
pass_plugin_args
field to theCommand
object.PluginInvoker.exec_args
to callself.plugin.exec_args
, ifcommand_config.pass_plugin_args
is true.meltano/src/meltano/core/plugin_invoker.py
Lines 292 to 298 in d59a7c9
This will allow Meltano to call
tap-example --config ... --test
under the hood.With that, the following config
should allow
meltano test tap-stackexchange
to work as expected.The text was updated successfully, but these errors were encountered: