Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JsonEncodingException & JsonDecodingException #526

Open
stloyd opened this issue Jun 7, 2023 · 1 comment
Open

Remove JsonEncodingException & JsonDecodingException #526

stloyd opened this issue Jun 7, 2023 · 1 comment
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request

Comments

@stloyd
Copy link
Contributor

stloyd commented Jun 7, 2023

There is no point in adding an additional layer with JsonEncodingException & JsonDecodingException over the exceptions thrown by the PHP itself.
@brunoocasali brunoocasali added enhancement New feature or request breaking-change The related changes are breaking for the users labels Jul 11, 2023
@norkunas
Copy link
Collaborator

Additionally given that there is PSR18 we also don't need Meilisearch\Contracts\Http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stloyd @norkunas @brunoocasali