Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails downloading for videos older than download cap #482

Open
Nairou opened this issue Mar 5, 2024 · 5 comments
Open

Thumbnails downloading for videos older than download cap #482

Nairou opened this issue Mar 5, 2024 · 5 comments

Comments

@Nairou
Copy link

Nairou commented Mar 5, 2024

I have YouTube sources added which contain thousands of videos. However, I only care about new videos, as I'm transitioning away from direct YouTube viewing, so I have the Download Cap set to 1 week for each source. I only care about videos from the last week, and new ones as they arrive.

However, TubeSync is still downloading thumbnails for EVERY video in each source. Looking at the queued tasks, there are thousands of tasks waiting to download very old thumbnails. It can take several hours for it to work through those and get to the actual videos. This also causes the database file to get very large.

Is this intended behavior, or can it be changed to entirely ignore downloads of content older than the download cap?

@meeb
Copy link
Owner

meeb commented Mar 7, 2024

The thumbnail issue is half by design and half I've not written a solution for it yet. The database itself will get large though as regardless of the thumbnails as you still need to get metadata for each item, even old items.

@Nairou
Copy link
Author

Nairou commented Mar 7, 2024

Understandable about the database size. Is there a reason thumbnail downloads can't follow the same rules as video downloads?

@meeb
Copy link
Owner

meeb commented Mar 7, 2024

Not especially, other than it's quite annoying to account for all eventualities. For example you modify the "keep" date on a source and there's currently no way to detect existing thumbnails, so you'd need to scan the disk to check for missing thumbnails if you extended the cap from 1 to 2 weeks and queue tasks for the missing ones. And the same in reverse if you shorten the cap.

It's perfectly possible, it just wasn't that big of an issue for most people to wait a bit when you add a big channel. I'll get around to it at some point.

The other option is I just hack in a basic "if" and then handle people creating issues for why some thumbnails are missing.

@Nairou
Copy link
Author

Nairou commented Mar 7, 2024

For example you modify the "keep" date on a source and there's currently no way to detect existing thumbnails, so you'd need to scan the disk to check for missing thumbnails if you extended the cap from 1 to 2 weeks and queue tasks for the missing ones. And the same in reverse if you shorten the cap.

Are these steps already being done for videos? i.e. modifying the keep date, and either deleting or re-downloading videos to match. If thumbnails were deleted when their videos get deleted, and the thumbnail download task was always queued at the same time a video download task was queued, I would think no extra checks would be needed.

But... I can also appreciate that things might currently work differently, and this isn't a priority. 😄 Thanks for the explanations!

@meeb
Copy link
Owner

meeb commented Mar 7, 2024

Yes, a record is kept of downloaded media and that is recalculated if you change a cap. Metadata like subtitles, NFO files and thumbnails are not currently explicitly tracked. They probably should have been from the start, though. They would be redownloaded if a media item was considered missing and redownloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants