Skip to content

Commit 156442e

Browse files
committed
Fail on missing Ready Worker nodes
Previously it was just skiping but it hides that we don't run tests and still getting a green result
1 parent 8589575 commit 156442e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/e2e/far_e2e_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ func getReadyWorkerNodes() *corev1.NodeList {
270270
}
271271
}
272272
if len(readyWorkerNodes.Items) < 1 {
273-
Skip("There isn't an available (and ready) worker node in the cluster")
273+
Fail("There isn't an available (and ready) worker node in the cluster")
274274
}
275275
return readyWorkerNodes
276276
}
@@ -279,7 +279,7 @@ func getReadyWorkerNodes() *corev1.NodeList {
279279
// and then the node is removed from the list of available nodes
280280
func pickRemediatedNode(availableNodes *corev1.NodeList) *corev1.Node {
281281
if len(availableNodes.Items) < 1 {
282-
Skip("There isn't an available (and ready) worker node in the cluster")
282+
Fail("There isn't an available (and ready) worker node in the cluster")
283283
}
284284
// Generate a random seed based on the current time
285285
r := rand.New(rand.NewSource(time.Now().UnixNano()))

0 commit comments

Comments
 (0)