chore: lint with @medic/eslint-config (#662)

* core: uplift dependencies

* Bump eslint-webpack-plugin

* Bump googleapis

* Bump json2csv

* Bump mocha

* Bump sinon

* Bump uuid

* Clean up and add dependabot

* Fix dependabot.yml indentation

* Run auto-fixes

* Manually fix line wrapping

* Try setting root to true in skeleton eslint

* Fix up linting for e2e tests

* Fix sonar

* Remove unneeded dep from e2e tests

* Fix linting in skeleton files

Author: jkuester

.eslintrc

@@ -5,7 +5,8 @@
   },
   "extends": [
     "eslint:recommended",
-    "plugin:n/recommended"
+    "plugin:n/recommended",
+    "@medic"
   ],
   "parserOptions": {
     "ecmaVersion": 2022

package-lock.json

@@ -74,6 +74,7 @@
   "devDependencies": {
     "@commitlint/cli": "^19.7.1",
     "@commitlint/config-conventional": "^19.7.1",
+    "@medic/eslint-config": "^1.1.0",
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
     "body-parser": "^1.20.3",

package.json

@@ -3,11 +3,11 @@
 /* eslint-disable no-console */
 
 const options = [
-    '--instance', '--local', '--url', '--user',
-    '--help', '--shell-completion', '--supported-actions',
-    '--version', '--accept-self-signed-certs', '--skip-dependency-check',
-    '--skip-git-check', '--skip-translation-check', '--force',
-    ...require('../cli/supported-actions'),
+  '--instance', '--local', '--url', '--user',
+  '--help', '--shell-completion', '--supported-actions',
+  '--version', '--accept-self-signed-certs', '--skip-dependency-check',
+  '--skip-git-check', '--skip-translation-check', '--force',
+  ...require('../cli/supported-actions'),
 ];
 
 console.log(...options);

src/bin/shell-completion.js

@@ -1,7 +1,7 @@
 const fs = require('fs');
 
 const actions = fs.readdirSync(`${__dirname}/../fn`)
-                  .filter(name => name.endsWith('.js'))
-                  .map(name => name.substring(0, name.length - 3));
+  .filter(name => name.endsWith('.js'))
+  .map(name => name.substring(0, name.length - 3));
 
 module.exports = actions;

src/cli/supported-actions.js

@@ -1,6 +1,7 @@
 const supportedActions = require('./supported-actions');
 
 module.exports = () => {
+  /* eslint-disable max-len */
   console.log(`
 ${bold('NAME')}
   cht - Configure your CHT instances
@@ -69,6 +70,7 @@ ${bold('OPTIONS')}
   --force
     CAN BE DANGEROUS! Passes yes to all commands and any where that would prompt to overwrite changes will overwrite automatically. 
 `);
+  /* eslint-enable max-len */
 };
 
 const bold = text => `\x1b[1m${text}\x1b[0m`;

src/cli/usage.js

@@ -34,5 +34,5 @@ module.exports = {
     return formsList(db)
       .then(res => res.rows)
       .then(forms => Promise.all(forms.map(backup)));
-    }
+  }
 };

src/fn/backup-all-forms.js

@@ -16,10 +16,14 @@ const JSON_FILE_MATCHER = /^(.+)(\.json)$/;
 const configFileMatcher = (fileName) => {
   const jsFileMatchResult = fileName.match(JS_FILE_MATCHER);
   // the first element is always the whole matched string, then our first file name group
-  if (jsFileMatchResult) return jsFileMatchResult[1];
+  if (jsFileMatchResult) {
+    return jsFileMatchResult[1];
+  }
 
   const jsonFileMatchResult = fileName.match(JSON_FILE_MATCHER);
-  if (jsonFileMatchResult) return jsonFileMatchResult[1];
+  if (jsonFileMatchResult) {
+    return jsonFileMatchResult[1];
+  }
 
   return null;
 };
@@ -48,7 +52,9 @@ const compileAppSettingsForProject = async (projectDir, options) => {
   const oldTaskSchedulesPath = path.join(projectDir, 'tasks.json');
   if (fs.exists(oldTaskSchedulesPath)) {
     if (fs.exists(taskSchedulesPath)) {
-      throw new Error(`You have both ${taskSchedulesPath} and ${oldTaskSchedulesPath}.  Please remove one to continue!`);
+      throw new Error(
+        `You have both ${taskSchedulesPath} and ${oldTaskSchedulesPath}.  Please remove one to continue!`
+      );
     }
     warn(`tasks.json file is deprecated.  Please rename ${oldTaskSchedulesPath} to ${taskSchedulesPath}`);
     taskSchedulesPath = oldTaskSchedulesPath;
@@ -66,7 +72,10 @@ const compileAppSettingsForProject = async (projectDir, options) => {
   }
 
   if (!fs.exists(baseSettingsPath) && !fs.exists(appSettingsPath)) {
-    throw new Error('No configuration defined please create a base_settings.json file in app_settings folder with the desired configuration');
+    throw new Error(
+      'No configuration defined please create a base_settings.json file in app_settings folder ' +
+      'with the desired configuration'
+    );
   }
   if (fs.exists(baseSettingsPath)) {
     // using modular config so should override anything already defined in app_settings.json
@@ -105,8 +114,10 @@ const compileAppSettingsForProject = async (projectDir, options) => {
       appSettings.assetlinks = assetlinks;
     }
   } else {
-    warn(`app_settings.json file should not be edited directly.
-    Please create a base_settings.json file in app_settings folder and move any manually defined configurations there.`);
+    warn(
+      `app_settings.json file should not be edited directly.
+    Please create a base_settings.json file in app_settings folder and move any manually defined configurations there.`
+    );
     appSettings = fs.readJson(appSettingsPath);
   }
   appSettings.contact_summary = await compilation.compileContactSummary(projectDir, options);
@@ -128,7 +139,9 @@ const compileAppSettingsForProject = async (projectDir, options) => {
 
 function applyTransforms(app_settings, inherited) {
   function doDelete(target, rules) {
-    if (!Array.isArray(rules)) throw new Error('.delete should be an array');
+    if (!Array.isArray(rules)) {
+      throw new Error('.delete should be an array');
+    }
 
     rules.forEach(k => {
       const parts = k.split('.');
@@ -142,7 +155,9 @@ function applyTransforms(app_settings, inherited) {
   }
 
   function doReplace(target, rules) {
-    if (typeof rules !== 'object') throw new Error('.replace should be an object');
+    if (typeof rules !== 'object') {
+      throw new Error('.replace should be an object');
+    }
 
     Object.keys(rules)
       .forEach(k => {
@@ -159,14 +174,22 @@ function applyTransforms(app_settings, inherited) {
   function doMerge(target, source) {
     Object.keys(target)
       .forEach(k => {
-        if (Array.isArray(source[k])) target[k] = target[k].concat(source[k]);
-        else if (typeof source[k] === 'object') doMerge(target[k], source[k]);
-        else source[k] = target[k];
+        if (Array.isArray(source[k])) {
+          target[k] = target[k].concat(source[k]);
+        }
+        else if (typeof source[k] === 'object') {
+          doMerge(target[k], source[k]);
+        }
+        else {
+          source[k] = target[k];
+        }
       });
   }
 
   function doFilter(target, rules) {
-    if (typeof rules !== 'object') throw new Error('.filter should be an object');
+    if (typeof rules !== 'object') {
+      throw new Error('.filter should be an object');
+    }
 
     Object.keys(rules)
       .forEach(k => {
@@ -177,11 +200,15 @@ function applyTransforms(app_settings, inherited) {
           parts.shift();
         }
 
-        if (!Array.isArray(rules[k])) throw new Error('.filter values must be arrays!');
+        if (!Array.isArray(rules[k])) {
+          throw new Error('.filter values must be arrays!');
+        }
 
         Object.keys(t[parts[0]])
           .forEach(tK => {
-            if (!rules[k].includes(tK)) delete t[parts[0]][tK];
+            if (!rules[k].includes(tK)) {
+              delete t[parts[0]][tK];
+            }
           });
       });
   }

src/fn/compile-app-settings.js

@@ -12,12 +12,14 @@ module.exports = {
         promiseChain
           .then(() => info('Compressing PNG:', png, '…'))
           .then(() =>
-              exec(['pngout-medic', `'${png}'`])
-                .then(() => trace('Compressed', png))
-                .catch(e => {
-                  if(e.status === 2) {
-                    info('Unable to compress further.');
-                  } else throw e;
-                })),
-        Promise.resolve())
+            exec(['pngout-medic', `'${png}'`])
+              .then(() => trace('Compressed', png))
+              .catch(e => {
+                if(e.status === 2) {
+                  info('Unable to compress further.');
+                } else {
+                  throw e;
+                }
+              })),
+      Promise.resolve())
 };

src/fn/compress-pngs.js

@@ -15,6 +15,9 @@ module.exports = {
           .then(() => svgo.optimize(fs.read(path), { path }))
           .then(result => fs.write(path, result.data))
           .then(() => trace('Compressed', path))
-          .then(() => warn('Make sure you compare the content of your SVG files before merging to the default branch - sometimes optimising can change their contents!')),
-        Promise.resolve())
+          .then(() => warn(
+            'Make sure you compare the content of your SVG files before merging to the default branch ' +
+            '- sometimes optimising can change their contents!'
+          )),
+      Promise.resolve())
 };