Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Mealie Nightly Shortcuts Broken #4407

Open
5 of 6 tasks
broyuken opened this issue Oct 21, 2024 · 12 comments
Open
5 of 6 tasks

[BUG] - Mealie Nightly Shortcuts Broken #4407

broyuken opened this issue Oct 21, 2024 · 12 comments
Labels
bug Something isn't working v2 Version 2 Issue/PR

Comments

@broyuken
Copy link

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

Ever since upgrading mealie to the nightly version, my iOS shortcuts don't work. They bring me to a 404 page, and in the logs I see a 405 error code, Method Not Allowed.

Steps to Reproduce

Import iOS shortcut, fill out api key and gemini key and url, click import from a picture, scan a url or any option, and it fails. This used to work prior to upgrading.

Please provide relevant logs

INFO 2024-10-15T16:42:53 - [127.0.0.1:43254] 200 OK "GET /api/app/about HTTP/1.1"
DEBUG 2024-10-15T16:42:53 - Running minutely callbacks
DEBUG 2024-10-15T16:42:53 - Language set to en
INFO 2024-10-15T16:43:01 - [10.0.86.111:0] 405 Method Not Allowed "POST /api/recipes/create-url HTTP/1.1"
[15/Oct/2024:16:43:01 -0400] 405 10.0.86.111(172.30.32.1) POST /api/recipes/create-url HTTP/1.1 (BackgroundShortcutRunner/3036.0.7 CFNetwork/1568.100.1.2.1 Darwin/24.0.0)
INFO 2024-10-15T16:43:02 - [10.0.86.111:0] 200 OK "GET /api/users/self HTTP/1.1"
[15/Oct/2024:16:43:02 -0400] 200 10.0.86.111(172.30.32.1) GET /api/users/self HTTP/1.1 (Mozilla/5.0 (iPhone; CPU iPhone OS 18_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/130.0.6723.37 Mobile/15E148 Safari/604.1)
INFO 2024-10-15T16:43:24 - [127.0.0.1:55416] 200 OK "GET /api/app/about HTTP/1.1"
INFO 2024-10-15T16:43:41 - [10.0.86.138:0] 200 OK "GET /api/households/shopping/lists?perPage=-1 HTTP/1.1"
[15/Oct/2024:16:43:41 -0400] 200 10.0.86.138(172.30.32.1) GET /api/households/shopping/lists?perPage=-1 HTTP/1.1 (AioMealie/0.9.3)
INFO 2024-10-15T16:43:41 - [10.0.86.138:0] 200 OK "GET /api/households/shopping/items?queryFilter=shoppingListId%3D35965614-616a-41ce-8ac0-17f65fa7fdb6&orderBy=position&orderDirection=asc&perPage=-1 HTTP/1.1"
[15/Oct/2024:16:43:41 -0400] 200 10.0.86.138(172.30.32.1) GET /api/households/shopping/items?queryFilter=shoppingListId%3D35965614-616a-41ce-8ac0-17f65fa7fdb6&orderBy=position&orderDirection=asc&perPage=-1 HTTP/1.1 (AioMealie/0.9.3)
INFO 2024-10-15T16:43:54 - [127.0.0.1:43292] 200 OK "GET /api/app/about HTTP/1.1"
INFO 2024-10-15T16:44:24 - [127.0.0.1:58488] 200 OK "GET /api/app/about HTTP/1.1"
INFO 2024-10-15T16:44:35 - [10.0.86.111:0] 200 OK "GET /api/groups/self HTTP/1.1"
[15/Oct/2024:16:44:35 -0400] 200 10.0.86.111(172.30.32.1) GET /api/groups/self HTTP/1.1 (BackgroundShortcutRunner/3036.0.7 CFNetwork/1568.100.1.2.1 Darwin/24.0.0)
INFO 2024-10-15T16:44:42 - [10.0.86.111:0] 405 Method Not Allowed "POST /api/recipes/create-url HTTP/1.1"
[15/Oct/2024:16:44:42 -0400] 405 10.0.86.111(172.30.32.1) POST /api/recipes/create-url HTTP/1.1 (BackgroundShortcutRunner/3036.0.7 CFNetwork/1568.100.1.2.1 Darwin/24.0.0)
INFO 2024-10-15T16:44:43 - [10.0.86.111:0] 200 OK "GET /api/users/self HTTP/1.1"
[15/Oct/2024:16:44:43 -0400] 200 10.0.86.111(172.30.32.1) GET /api/users/self HTTP/1.1 (Mozilla/5.0 (iPhone; CPU iPhone OS 18_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/130.0.6723.37 Mobile/15E148 Safari/604.1)
INFO 2024-10-15T16:44:55 - [127.0.0.1:47038] 200 OK "GET /api/app/about HTTP/1.1"

Mealie Version

Nightly version cba381c

Deployment

Other (please specify below)

Additional Deployment Details

home assistant addon

https://github.com/alexbelgium/hassio-addons/tree/master/mealie

@broyuken broyuken added bug Something isn't working triage labels Oct 21, 2024
@michael-genson
Copy link
Collaborator

/api/recipes/create-url

This URL has changed, you need to switch to /api/recipes/create/url

More info here: https://docs.mealie.io/contributors/developers-guide/migration-guide/

@Kuchenpirat
Copy link
Collaborator

there are currently a bunch of breaking changes in nightly as we are close to a mealie v2 release so thre might be more stuff that is broken.

@broyuken
Copy link
Author

I changed that in the shortcut, but I'm still getting the 404. The url in the address bar with the 404 is https://mealie.xxxxxx.com/g//r/ and the double / is not a typo.

@michael-genson
Copy link
Collaborator

Looks like the shortcut is trying to redirect you to the recipe page, but isn't properly including the group or recipe slug.
FYI a normal recipe URL looks like this: https://mealie.xxx.com/g/home/r/my-new-recipe

Seems like an issue with the shortcut

@broyuken
Copy link
Author

So should I just wait until a v2 release? I assume there will be an updated shortcut to go along with that release?

@michael-genson
Copy link
Collaborator

We don't have an official shortcut, the shortcut guide was added by a community member. I imagine they're the ones who maintain the shortcut but I'm not sure

@hunterjm any insight on this one?

@hunterjm
Copy link
Contributor

I can create a “v2” shortcut, but since I don’t currently run nightly I haven’t had the need to at this point. Will see if I have some time this week and will open a docs PR referencing this when I do.

@michael-genson
Copy link
Collaborator

Thanks! For what it's worth, we're planning on releasing V2 soon if you want to wait until then (so you can test on your instance)

@hunterjm
Copy link
Contributor

Thanks! For what it's worth, we're planning on releasing V2 soon if you want to wait until then (so you can test on your instance)

I’ve got the repo cloned already (somewhere), so can test locally no problem. Changes don’t seem too crazy either, so may just yolo it when I get back to a Mac (pain to try and edit on a phone) and have @broyuken give it a spin.

@broyuken
Copy link
Author

Be happy to help test it!

@Kuchenpirat Kuchenpirat added v2 Version 2 Issue/PR and removed triage labels Oct 21, 2024
@ant385525
Copy link

In the meantime this is what I've been using. It's my first time doing anything with Apple shortcuts so I'd swap to the "official" (tested) one once that's posted, but this seems to work alright. 1 thing though, I have Mealie connected to Openai, so this does NOT use google Gemini to parse the text in images it just sends the image directly to Mealie. If you don't have Openai set up don't use this to upload recipe images, but it should work fine for URLs and parsing URLs from images

Link

@joca879
Copy link

joca879 commented Nov 5, 2024

I've just been aware of this awesome software and yesterday I tried to implement the shortcut but it gives the 404 error page.
Has there been any development in regards of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2 Version 2 Issue/PR
Projects
None yet
Development

No branches or pull requests

6 participants