[BUG] - Removing a recipe ingredient doesn't remove its links to steps

[YodaDaCoda]

First Check

• This is not a feature request.
• I added a very descriptive title to this issue (title field is above this).
• I used the GitHub search to find a similar issue and didn't find it.
• I searched the Mealie documentation, with the integrated search.
• I already read the docs and didn't find an answer.
• This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When a recipe ingredient is removed from the recipe, any recipe-step links for that ingredient are not removed from the steps.

Steps to Reproduce

1. Create a new recipe or edit an existing one
2. Link an ingredient to a step
3. Remove the ingredient from the recipe
4. Open the ingredient's JSON and observe that there exists an ingredientReferences on the step without a corresponding recipeIngredient.

Please provide relevant logs

N/A

Mealie Version

v1.10.2

Deployment

Docker (Linux)

Additional Deployment Details

No response

[YodaDaCoda]

I discovered this when the Mealient app for Android wouldn't display one of my recipes after editing it. While I do think Mealient should handle this situation more gracefully, Mealie should avoid this in the first place.

kirmanak/Mealient#284

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[YodaDaCoda]

Can this be re-opened?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[YodaDaCoda]

I tried to figure out how to do this some weeks ago but couldn't see a clear path where I might make changes. Happy to try again with some direction?

[michael-genson]

You'll probably want to add a check in the recipe service upon updating to remove any ingredient links for non-existent ingredients:

https://github.com/mealie-recipes/mealie/blob/mealie-next/mealie/services/recipe/recipe_service.py