Feature/alias elements #94
Conversation
handle deprecation of x.getchildren()
test adding alias to multiple elements
move httprettu to a test_require
Harmonised Doc Strings so Sphinx Autodoc works
Partition the Builder examples
Added docstrings to be able to autogen docs
run BLACK formatter over the module
Ran BLACK reformatting on the module (no code changes) Reformatted documents (specifically around presentation of ..note sections)
docs/source/classes_builders.rst
Outdated
| Metadata Builders | ||
| ================= | ||
|
|
||
| Note: Any Class with the Prefix **Mdsol** represents a Medidata Rave specific extension |
There was a problem hiding this comment.
Since this is rst do you want to make these:
..note:: Any Class with the Prefix **Mdsol** represents a Medidata Rave specific extension ?
rwslib/builders/metadata.py
Outdated
| OrderNumber=str(self.order_number), | ||
| Mandatory=bool_to_yes_no(self.mandatory)) | ||
| params = dict(StudyEventOID=self.oid, Mandatory=bool_to_yes_no(self.mandatory)) | ||
| if self._order_number: |
There was a problem hiding this comment.
0 is an int but would be dropped here. I am not sure that 0 is allowed as an Ordinal anyway, just noting it.
There was a problem hiding this comment.
Great point, updated!
|
Nice work @glow-mdsol Much appreciated. |
| @@ -461,7 +461,7 @@ def __init__(self, oid, order_number=None, mandatory=False): | |||
| def build(self, builder): | |||
| """Build XML by appending to builder""" | |||
| params = dict(StudyEventOID=self.oid, Mandatory=bool_to_yes_no(self.mandatory)) | |||
| if self._order_number: | |||
| if self._order_number is not None: | |||
There was a problem hiding this comment.
Does it have to be a cardinal number? I don't know what Rave enforces here. Can you have an Ordinal or 0 or -1 ? ODM recommends numbers starting at 1 but not sure what Rave requires?
There was a problem hiding this comment.
Rave just seems to parse it as an int.....
|
Changes merged across to #95 |
@iansparks - bundle up of new features and fixes as requested by @anewbigging
getChildren()