Skip to content

Commit 3de4b0d

Browse files
committed
Stop enforcing elfprooef algorithm for Dutch IBANS
1 parent c467335 commit 3de4b0d

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

CHANGELOG.rst

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ Changelog
55

66
Versions follow `CalVer <http://www.calver.org/>`_ with the scheme ``YY.0M.Micro``.
77

8+
`2024.06.0`_ - 2024/06/04
9+
-------------------------
10+
Changed
11+
~~~~~~~
12+
* Stop using the "elfprooef" algorithm when validating Dutch IBANs, since the administrative
13+
authority says it should not be checked any more.
14+
15+
816
`2024.05.4`_ - 2024/05/25
917
-------------------------
1018
Added
@@ -640,6 +648,7 @@ Added
640648
* Added :attr:`.BIC.country` and :attr:`.IBAN.country`.
641649

642650

651+
.. _2024.06.0: https://github.com/mdomke/schwifty/compare/2024.05.4...2024.06.0
643652
.. _2024.05.4: https://github.com/mdomke/schwifty/compare/2024.05.3...2024.05.4
644653
.. _2024.05.3: https://github.com/mdomke/schwifty/compare/2024.05.2...2024.05.3
645654
.. _2024.05.2: https://github.com/mdomke/schwifty/compare/2024.05.1...2024.05.2

schwifty/checksum/netherlands.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@
66
from schwifty.domain import Component
77

88

9-
@checksum.register("NL")
109
class DefaultAlgorithm(checksum.Algorithm):
10+
"""This algorithm is not used anymore for Dutch IBANs and is therefore not registered anymore.
11+
12+
See https://www.betaalvereniging.nl/betaalproducten-en-diensten/iban/ibannext/ for more
13+
information
14+
"""
15+
1116
name = "default"
1217
accepts: ClassVar[list[Component]] = [Component.ACCOUNT_CODE]
1318

tests/test_checksum.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,5 @@ def test_belgium_checksum_checksum_edge_case() -> None:
103103
assert algorithms["BE:default"].validate(["050", "0000177"], "97") is True
104104

105105

106-
def test_netherlands_checksum() -> None:
107-
assert algorithms["NL:default"].validate(["0417164300"], "") is True
108-
109-
110106
def test_norway_checksum_checksum_edge_case() -> None:
111107
assert algorithms["NO:default"].validate(["6042", "143964"], "0") is True

0 commit comments

Comments
 (0)