Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declarativeNetRequest: Some methods missing await in the Syntax code #37866

Open
erosman opened this issue Jan 29, 2025 · 0 comments
Open

declarativeNetRequest: Some methods missing await in the Syntax code #37866

erosman opened this issue Jan 29, 2025 · 0 comments
Labels
Content:WebExt WebExtensions docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@erosman
Copy link
Contributor

erosman commented Jan 29, 2025

MDN URL

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/getDynamicRules

What specific section or headline is this issue about?

Syntax

What information was incorrect, unhelpful, or incomplete?

The issue is obseerved on multiple pages:

declarativeNetRequest.getDynamicRules
declarativeNetRequest.getMatchedRules
declarativeNetRequest.isRegexSupported
declarativeNetRequest.setExtensionActionOptions
declarativeNetRequest.updateDynamicRules
declarativeNetRequest.updateSessionRules
declarativeNetRequest.updateSessionRules
declarativeNetRequest.updateStaticRules

Example:

let gettingDynamicRules = browser.declarativeNetRequest.getDynamicRules();

Other methods show the code with await (as it should) e.g. declarativeNetRequest.getAvailableStaticRuleCount

let count = await browser.declarativeNetRequest.getAvailableStaticRuleCount();

What did you expect to see?

As they return a promise, the code should have await

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@erosman erosman added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 29, 2025
@github-actions github-actions bot added the Content:WebExt WebExtensions docs label Jan 29, 2025
@erosman erosman changed the title declarativeNetRequest: Some methods missing await it the Syntax code declarativeNetRequest: Some methods missing await in the Syntax code Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

1 participant