Add a way to run already existing containers which stop after launch

Author: thatside-zaraffa

core/runjob.go

@@ -16,26 +16,36 @@ func init() {
 
 type RunJob struct {
 	BareJob
-	Client  *docker.Client `json:"-"`
-	User    string         `default:"root"`
-	TTY     bool           `default:"false"`
-	Delete  bool           `default:"true"`
-	Image   string
-	Network string
+	Client    *docker.Client `json:"-"`
+	User      string         `default:"root"`
+	TTY       bool           `default:"false"`
+	Delete    bool           `default:"true"`
+	Image     string
+	Network   string
+	Container string
 }
 
 func NewRunJob(c *docker.Client) *RunJob {
 	return &RunJob{Client: c}
 }
 
 func (j *RunJob) Run(ctx *Context) error {
-	if err := j.pullImage(); err != nil {
-		return err
-	}
+	var container *docker.Container
+	var err error
+	if j.Image != "" && j.Container == "" {
+		if err = j.pullImage(); err != nil {
+			return err
+		}
 
-	container, err := j.buildContainer()
-	if err != nil {
-		return err
+		container, err = j.buildContainer()
+		if err != nil {
+			return err
+		}
+	} else {
+		container, err = j.getContainer(j.Container)
+		if err != nil {
+			return err
+		}
 	}
 
 	if err := j.startContainer(ctx.Execution, container); err != nil {
@@ -46,7 +56,10 @@ func (j *RunJob) Run(ctx *Context) error {
 		return err
 	}
 
-	return j.deleteContainer(container.ID)
+	if j.Container == "" {
+		return j.deleteContainer(container.ID)
+	}
+	return nil
 }
 
 func (j *RunJob) pullImage() error {
@@ -98,6 +111,14 @@ func (j *RunJob) startContainer(e *Execution, c *docker.Container) error {
 	return j.Client.StartContainer(c.ID, &docker.HostConfig{})
 }
 
+func (j *RunJob) getContainer(id string) (*docker.Container, error) {
+	container, err := j.Client.InspectContainer(id)
+	if err != nil {
+		return nil, err
+	}
+	return container, nil
+}
+
 const (
 	watchDuration      = time.Millisecond * 100
 	maxProcessDuration = time.Hour * 24

test/run-job/docker-compose.yml

@@ -0,0 +1,13 @@
+version: "3"
+
+services:
+  ofelia:
+    build:
+      dockerfile: Dockerfile
+      context: ../../.
+    volumes:
+      - /var/run/docker.sock:/var/run/docker.sock
+      - ./ofelia.ini:/etc/ofelia/config.ini
+
+  job:
+    image: hello-world

test/run-job/ofelia.ini

@@ -0,0 +1,3 @@
+[job-run"job"]
+schedule = "*/1 * * * *"
+container = ofelia_job_1