Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCPLGen's skip_events int parameter imposes a 2^31 event limit for processing MCPL files #18

Open
MilanKlausz opened this issue May 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@MilanKlausz
Copy link
Contributor

MCPL files containing more that 2^31 events are difficult to processes due to the skip_events parameter of the MCPL generator being an integer.

The issue occurs when I run a McStas simulation to produce an MCPL file - containing neutrons scattered on a sample - that I want to use a source of particles for the subsequent Geant4 simulation of the detection process. I use the ess_dmscutils_submit tool to submit a lot of simulation jobs with 1e5 events in each, using the skip_events parameter in accordance with the job id, but that stops working when it reaches the 2^31 integer limit.

My current solution is splitting the large MCPL files, and processing them separately, but it would be nice to avoid that extra manual step (which is also a potential source of errors).

@MilanKlausz MilanKlausz added the enhancement New feature or request label May 27, 2023
@tkittel
Copy link
Member

tkittel commented May 27, 2023

Right. The underlying mcpl interface uses 64 bit integers though, so the fix should not be so hard. But of course, might require changes in all projects, which is annoying. Perhaps the sinplest is to add a new integer64 parameter type in dgcode?

@tkittel
Copy link
Member

tkittel commented May 27, 2023

Or perhaps simply as a short term workaround use a string parameter?

@tkittel tkittel transferred this issue from mctools/dgcode Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants