Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strategy parameters does not match the standard #14

Open
Tyki opened this issue Sep 26, 2019 · 1 comment
Open

Strategy parameters does not match the standard #14

Tyki opened this issue Sep 26, 2019 · 1 comment

Comments

@Tyki
Copy link

Tyki commented Sep 26, 2019

Hi,

It looks like the signature of the function Strategy does not respect the standard.
For example : https://github.com/jaredhanson/passport-local/blob/master/lib/strategy.js

The first parameter is the options and the second one is the verify.
When using passport.use, the definition should be

passport.use(options, new CustomStrategy(....))

Would you appreciate a PR on this and release a new major version of the passport-custom with this breaking-change ?
@mbell8903
Copy link
Owner

Sure addd the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbell8903 @Tyki