Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public build/package cache #47

Open
maxmcd opened this issue Nov 17, 2021 · 1 comment
Open

Public build/package cache #47

maxmcd opened this issue Nov 17, 2021 · 1 comment

Comments

@maxmcd
Copy link
Owner

maxmcd commented Nov 17, 2021

No description provided.

@maxmcd
Copy link
Owner Author

maxmcd commented Dec 19, 2021

Basic build server is complete. Need to handle:

  • Checking to see if a package exists before we build it (complicated by sub-packages)
    • What if only some of the new packages are new?
  • Uploading packages to the cache, handling package list operations
  • Uploading source and build graph cache (does build graph cache make sense now? Maybe punt)

How do repo packages work with multiple versions? Some thoughts:

  • Must only fetch packages from main branch or else we run into weird issues where people are publishing things from obscure branched before they are merged/approved.
  • Lockfile doesn't matter, as long as the dependency is in bramble.toml we're allowed to update the lockfile since it isn't used when the package is a sub-package.
  • Instead of building everything first and then committing it we should build things in dependency order if there are shared dependencies. We can publish parent dependencies first and then try and build the children, if the children fail that's fine.
  • We must keep track of path and version number for in-repo dependencies. The paths and versions must be accurate. That way when building in the build server we can replace the path with a published version of that package. Local tooling should regularly check/fix this kind of thing.
  • Think about import paths with major versions next...

@maxmcd maxmcd closed this as completed Dec 30, 2021
@maxmcd maxmcd reopened this Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant