Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Internal links in markdown chart column names breaks chart #48

Open
manunamz opened this issue Feb 12, 2021 · 3 comments
Open
Labels
bug Something isn't working

Comments

@manunamz
Copy link
Contributor

manunamz commented Feb 12, 2021

Internal link usage break charts:

Without internal links:
Screen Shot 2021-02-15 at 10 25 50 AM
Screen Shot 2021-02-15 at 10 25 56 AM

With internal links:
Screen Shot 2021-02-15 at 10 24 47 AM
Screen Shot 2021-02-15 at 10 25 05 AM

@manunamz manunamz changed the title Request support for markdown charts Request support for backlinks in markdown charts Feb 15, 2021
@manunamz manunamz changed the title Request support for backlinks in markdown charts Backlinks in markdown chart column names breaks chart Feb 15, 2021
@manunamz manunamz changed the title Backlinks in markdown chart column names breaks chart Internal links in markdown chart column names breaks chart Feb 17, 2021
@meewgumi
Copy link
Contributor

Hi @manunamz, I fixed this on my site by switching to Commonmark instead of Kramdown. Here's a Demo table with wikilink

How to switch to Commonmark:

@maximevaillancourt maximevaillancourt added the bug Something isn't working label May 31, 2021
@manunamz
Copy link
Contributor Author

manunamz commented Jun 11, 2021

I was able to fix this without switching to CommonMark. I will post what I did as soon as I re-figure it out.

@manunamz
Copy link
Contributor Author

manunamz commented Jun 12, 2021

Ok, so it's not just having internal links in the chart, it's having missing internal links that breaks the chart.

If the internal links aren't missing then tables work with internal links in them:

Screen Shot 2021-06-11 at 8 39 02 PM

Screen Shot 2021-06-11 at 8 36 28 PM

Another oddity tho, and this is why when I originally posted the bug I thought it was just internal links breaking the tables, if the internal link/filename contains a dash it breaks the table (or at least marks it as a missing note, which breaks the table):

Screen Shot 2021-06-11 at 8 44 55 PM

Screen Shot 2021-06-11 at 8 45 30 PM

(The km.app.roam-research is not missing in either scenario)

I'm guessing this bug will also show up in the CommonMark Parser, but that's just a guess.

@manunamz manunamz changed the title Internal links in markdown chart column names breaks chart Missing Internal links in markdown chart column names breaks chart Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants