Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error coercion in handlers #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove error coercion in handlers #29

wants to merge 1 commit into from

Conversation

snnsnn
Copy link

@snnsnn snnsnn commented Apr 19, 2024

Closes #28

@mihar-22
Copy link
Member

Looks good to me! We just need to remove the version bump and changelog changes since they're automated on release.

@snnsnn
Copy link
Author

snnsnn commented Apr 19, 2024 •
edited

We just need to remove the version bump and changelog changes since they're automated on release.

So, changing src/core.ts file is enough? No other edits.

No problem, but how do we communicate it to automation that it is a breaking change?

Edit: I did issue a force push with the commit that updates the file only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please do not coerce errors
2 participants
@snnsnn @mihar-22