Please do not coerce errors

[snnsnn]

signals/src/core.ts

Line 268 in 65f7fe9

function handleError(scope: Scope | null, error: unknown) {

Once we had a discussion on keeping the language semantics when handling errors in SolidJS. Solid did not allow throwing falsy values as errors even though the language permits it. I see you follow somewhat similar path, but coercing errors may not be good idea from the consumer's perspective. Why not keep them as is:

let handled = false;
for (let i = 0, len = handlers.length; i < len; i++) {
  try {
    handlers[i](error);
    handled = true;
    break; // Error is handled.
  } catch (rethrown: any) {
    error = rethrown;
  }
}
if (!handled) throw error;

Is there a valid reason for coercion?

[mihar-22]

Good point, let's remove it. Can't remember why but we shouldn't mess with it. Happy to pull in a PR. It's breaking change so we'll need to bump to v6.

[snnsnn]

Good point, let's remove it. Can't remember why but we shouldn't mess with it. Happy to pull in a PR. It's breaking change so we'll need to bump to v6.

Ok. It is coming..